Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

557 Add fn:binary-resource #1587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

557 Add fn:binary-resource #1587

wants to merge 1 commit into from

Conversation

michaelhkay
Copy link
Contributor

Adds the function fn:binary-resource

Also fixes some inconstencies in the handling of static/executable base URI in other resource access functions.

Fix #557

@michaelhkay michaelhkay added XQFO An issue related to Functions and Operators Feature A change that introduces a new feature Tests Needed Tests need to be written or merged labels Nov 18, 2024
ChristianGruen
ChristianGruen reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@ChristianGruen ChristianGruen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got never fully acquainted with the function name fn:unparsed-text, but as it was not called fn:text-resource, I think that fn:unparsed-binary could be a more intuitive name for the new function.

@ChristianGruen ChristianGruen added the Blocked PR is blocked (has merge conflicts, doesn't format, etc.) label Jan 1, 2025
@ndw
Copy link
Contributor

ndw commented Jan 20, 2025

The name unparsed-binary would put it near unparsed-text lexicographically...

@michaelhkay
Copy link
Contributor Author

Yes, consistency is probably desirable even if it means repeating the mistakes of the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianGruen ChristianGruen ChristianGruen left review comments

Assignees
No one assigned
Labels
Blocked PR is blocked (has merge conflicts, doesn't format, etc.) Feature A change that introduces a new feature Tests Needed Tests need to be written or merged XQFO An issue related to Functions and Operators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fn:unparsed-binary: accessing and manipulating binary types
3 participants
@michaelhkay @ndw @ChristianGruen