-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/refactor videomode folder #237
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about if we have the video_mode/__init__.py
import the original functions/classes which are now in live_mode? This way the code remains backwards compatible
@nulinspiratie What I had in mind was this
But
|
@TheoLaudatQM looks like a nice solution! All good from my end |
We can merge if we're okay with the breaking changes and the lack of backward compatibility. Otherwise, we can make it compatible. |
Hmm, if we want to maintain backwards compatibility, we could also opt for the following: video_mode/videomode.py from qualang_tools.live_mode import LiveMode
import warnings
class VideoMode(LiveMode):
def __init__(self, qm: QuantumMachine, parameters: Union[Dict, ParameterTable]):
warnings.warn("the video_mode module is deprecated, please import live_mode instead", DeprecationWarning,
stacklevel=0)
super().__init__(self, qm, parameters) We would then need to rename the new |
Rename the module called video_mode into live_mode to avoid confusion with the video mode tool used to tune up quantum dots devices.
We can still debate on the name if you think that another one would be more relevant for this tool which is used for updating parameters from a QUA program while the program is running in an asynchronous manner.