Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno - use --allow-all to avoid issues with reading / writing on network drive #11385

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Nov 13, 2024

This is an issue with Deno 1.46.3 where --allow-read and --allow-write does not give enough permissions to read / write with files on network drive

closes #11332

@cscheid as discussed I replaced with --allow-all. I did it everywhere (Linux / Windows) but it seems from deno report the issue is Windows only, so we could also do that only for windows. So for the future, it seems easier to do the same everywhere. I added a comment to remember we could try back using specific flags.

BTW, by doing --allow-all, we are adding two more permissions compared to current situation

 -S, --allow-sys[=<API_NAME>...]        Allow access to OS information. Optionally allow specific APIs by function name.
      --allow-hrtime                     Allow high-resolution time measurement. Note: this can enable timing attacks and fingerprinting.

Those two where not activated in our individual flag listing. I tried something like --allow-all --deny-sys --deny-hrtime but it seems --allow-all always win, so it is not working as expected.

…ork drive

This is an issue with Deno 1.46.3 where --allow-read and --allow-write does not give enough permissions to read / write with files on network drive

closes #11332
@cderv cderv requested a review from cscheid November 13, 2024 10:53
@cderv
Copy link
Collaborator Author

cderv commented Nov 14, 2024

@cscheid the user confirmed that the build from this PR is fixing the remote drive problem.

So --allow-all seems to be the solution for it.

Good to merge ?

@cscheid
Copy link
Collaborator

cscheid commented Nov 14, 2024

Yes, let's merge. We'll revert to fine-grained permissions when Deno fixes the upstream bug. Thank yoU!

@cscheid cscheid merged commit 135024a into main Nov 14, 2024
62 checks passed
@cscheid cscheid deleted the windows/deno-flag branch November 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno issue with files on network drives
2 participants