deno - use --allow-all to avoid issues with reading / writing on network drive #11385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue with Deno 1.46.3 where --allow-read and --allow-write does not give enough permissions to read / write with files on network drive
closes #11332
@cscheid as discussed I replaced with
--allow-all
. I did it everywhere (Linux / Windows) but it seems from deno report the issue is Windows only, so we could also do that only for windows. So for the future, it seems easier to do the same everywhere. I added a comment to remember we could try back using specific flags.BTW, by doing
--allow-all
, we are adding two more permissions compared to current situationThose two where not activated in our individual flag listing. I tried something like
--allow-all --deny-sys --deny-hrtime
but it seems--allow-all
always win, so it is not working as expected.