Use importlib.metadata to get the python module version #7974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is available since Python 3.8, oldest active version at date of this commit. This is needed because `__version__` has been removed from jupyter_core 5.5.1 and quarto fails to find python.
Yes, I think Quarto policy should be "we don't support EOL'd versions of Python" (if that's not what it already is, and I just don't know where we state it). |
|
@cwickham any idea where we should put this in our documentation ? Do you think highlights for 1.4 is a good place ? |
|
After talking with Charles, we decided to do this slightly more conservatively and not break in Python 3.7. I'll make the change on |
cscheid
added a commit
that referenced
this pull request
Dec 19, 2023
|
Sure. This what I wanted to do at the beginning. Should follow my hunch next time 😅 Thanks for the fix. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is available since Python 3.8, oldest active version at date of this commit.
This is needed because
__version__has been removed from jupyter_core 5.5.1 and quarto fails to find python.fixes #7964
I believe we should add somewhere that Quarto 1.4 now requires Python 3.8 as minimal version. We should probably make it clear about the EOL rule.
Should it be in Changelog highlights or elsewhere ?