Add TokenMemoryCache
#2137
Open
Add TokenMemoryCache
#2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokenMemoryCache is a new implementation of TokenStore. TokenMemoryCache is designed to store up to 2 tokens per server (this is configurable) for up to 256 servers (this is also configurable), with a LRU eviction policy. This is so that it works harmoniously with rustls::ClientSessionMemoryCache, which by default stores resumption state for up to 256 servers with a LRU eviction policy. Although this does create a complex intrusive structure, this commit contains unit tests which assert that it maintains not only the same external behavior but also isomorphic internal structure to an oracle implementation based on stdlib types, under a large number of deterministically randomized operations. This should give us a high degree of assurance against implementation errors.
Deletes SimpleTokenStore. Test code can now rely on TokenMemoryCache, which is set by default.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
TokenMemoryCache, and makes it the defaultTokenStorefor clients.