Skip to content

Commit

Permalink
ci: move create tag into create release step for release (#5958)
Browse files Browse the repository at this point in the history
There's no reason to do another setup step here to get git for a
one-liner.

More fixes for #5953.
  • Loading branch information
quisquous authored Nov 29, 2023
1 parent 1c3c6ae commit 1bb20b5
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ jobs:
mv publish/cactbot-release/cactbot/ cactbot
compress-archive cactbot cactbot-${{ needs.validate_tag.outputs.version }}.zip
shell: pwsh
- name: Create Tag
shell: bash
run: git tag "v${{ needs.validate_tag.outputs.version }}" && git push --tags
- name: Create Release
uses: ncipollo/release-action@v1
with:
Expand All @@ -123,12 +126,3 @@ jobs:
working-directory: npm-package
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

create_tag:
needs: [validate_tag, create_release]
runs-on: ubuntu-latest
if: ${{ github.repository == 'quisquous/cactbot' }}
steps:
- name: Create Tag
shell: bash
run: git tag "v${{ needs.validate_tag.outputs.version }}" && git push --tags

0 comments on commit 1bb20b5

Please sign in to comment.