raidboss: improve translation of timeline netregex #5962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #5939. This translates each parameter (only if needed) rather than the entire sync. It also prints out only the untranslated parameters in the find missing translations script / coverage report. This also improves the output of the translated timeline utility to use translated parameters and fixes a bug where it wouldn't have output any translated sync lines at all for netregex lines.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
…5962) Follow-up to #5939. This translates each parameter (only if needed) rather than the entire sync. It also prints out only the untranslated parameters in the find missing translations script / coverage report. This also improves the output of the translated timeline utility to use translated parameters and fixes a bug where it wouldn't have output any translated sync lines at all for netregex lines. 86f5ae1
quisquous
added a commit
that referenced
this pull request
Dec 1, 2023
This is a follow-up to #5962, which itself is related to #5939. I forgot that `find_missing_timeline_translations.ts` is only half of the testing picture and `test_timeline.ts` needed to be updated too. This was found by trying to test more lines and having test timeline complain that InCombat regex lines were not translated.
quisquous
added a commit
that referenced
this pull request
Dec 1, 2023
This is a follow-up to #5962, which itself is related to #5939. I forgot that `find_missing_timeline_translations.ts` is only half of the testing picture and `test_timeline.ts` needed to be updated too. This was found by trying to test more lines and having test timeline complain that InCombat regex lines were not translated.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
…5968) This is a follow-up to #5962, which itself is related to #5939. I forgot that `find_missing_timeline_translations.ts` is only half of the testing picture and `test_timeline.ts` needed to be updated too. This was found by trying to test more lines and having test timeline complain that InCombat regex lines were not translated. 6a3869f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5939.
This translates each parameter (only if needed) rather than the entire sync. It also prints out only the untranslated parameters in the find missing translations script / coverage report. This also improves the output of the translated timeline utility to use translated parameters and fixes a bug where it wouldn't have output any translated sync lines at all for netregex lines.