Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control how spaces are handed in query strings #609

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Control how spaces are handed in query strings #609

merged 6 commits into from
Jan 6, 2025

Conversation

hadley
Copy link
Member

@hadley hadley commented Dec 23, 2024

Fixes #432

jonthegeek
jonthegeek reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 typo (unless I'm missing reasoning behind the second %). This will definitely be useful! I can't remember which api it was for, but I definitely had to implement this in front of req_url_query() before!

R/req-url.R Outdated Show resolved Hide resolved
@hadley @jonthegeek
Update R/req-url.R
f0b1594 
Co-authored-by: Jon Harmon <[email protected]>
@hadley
Copy link
Member Author

hadley commented Jan 6, 2025

Thanks!

@hadley hadley merged commit e485d7f into main Jan 6, 2025
13 checks passed
@hadley hadley deleted the query-spaces branch January 6, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonthegeek jonthegeek jonthegeek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to use + in req_url_query()
2 participants
@hadley @jonthegeek