Merge pull request #604 from radiant-player/hotfix-nav-bar

Hotfix issue with nav-container attributes
radiant-player · Sep 14, 2016 · e13317c · e13317c
2 parents a87c9d9 + 347ce3d
commit e13317c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@ This file should follow the standards specified on [keepachangelog.com](http://k
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [unreleased]
+### Fixed
+* Hotfixed navigation bar issue causing crashes ([#604](https://github.com/radiant-player/radiant-player-mac/pull/604))
 
 ## [1.10.2] - 2016-08-19
 ### Fixed

diff --git a/radiant-player-mac/js/navigation.js b/radiant-player-mac/js/navigation.js
@@ -67,6 +67,11 @@ if (typeof window.GMNavigation === 'undefined') {
     buttonsContainer.parentNode.insertBefore(paddingElement, buttonsContainer);
 
     // Adjust the drawer navigation scrolling mode to accomodate the traffic light buttons.
-    var el = document.querySelector('#drawer #nav-container');
-    if (el) el.setAttribute('mode', '');
+    var navContainer = document.querySelector('#drawer #nav-container');
+    if (navContainer) {
+      navContainer.removeAttribute('mode');
+      var mode = document.createAttribute('mode');
+      mode.value = '';
+      navContainer.setAttributeNode(mode);
+    }
 }