Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chinese i18n #1256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mouyase
Copy link

@mouyase mouyase commented Dec 13, 2023

No description provided.

@ashgx
Copy link

ashgx commented Dec 13, 2023

置中对齐改成居中对齐会不会好点?
还有就是,使用自定义BIOS和固件,你可以在不加载ROM的情况下启动和浏览DS的固件,和实体机中一样.这句话怎么读起来怪怪的。。

@christopher3242
Copy link

Copy link
Owner

@rafaelvcaetano rafaelvcaetano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That for your effort in this translation! Since I don't have any handle on the language, I'll trust your translations and judgement regarding them. I just found some strings that were not translated and just want to make sure that you didn't forget them by accident. If those strings make more sense in English, just let me know and I'll merge the PR.

<item>横向</item>
</string-array>

<string-array name="background_portrait_mode_options">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translations.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't build this project, so I don't know some string context. If I can run this application, I will do better.

<item>LCD</item>
</string-array>

<string-array name="audio_interpolation_options">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translations for some items.


<string-array name="video_filtering_options">
<item>无</item>
<item>Linear</item>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this item, and the LCD one, can be translated. But unfortunately I don't know Chinese to know if that's that case or not, so I'd rather trust your judgement 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants