fix: remove Transaction

rai200890 · Dec 17, 2020 · a9d268b · a9d268b
1 parent 54708e9
commit a9d268b
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 15 deletions.
diff --git a/config/test.exs b/config/test.exs
@@ -22,6 +22,4 @@ config :ecto_job_scheduler, sanitizer: sanitize_fun
 
 config :logger, level: :warn
 
-config :ecto_job_scheduler, EctoJobScheduler.NewRelic.JobInstrumenter,
-  transaction: TransactionMock,
-  reporter: ReporterMock
+config :ecto_job_scheduler, EctoJobScheduler.NewRelic.JobInstrumenter, reporter: ReporterMock
diff --git a/lib/new_relic/job_instrumenter.ex b/lib/new_relic/job_instrumenter.ex
@@ -72,8 +72,4 @@ defmodule EctoJobScheduler.NewRelic.JobInstrumenter do
     do:
       Application.get_env(:ecto_job_scheduler, __MODULE__)[:reporter] ||
         NewRelic.Transaction.Reporter
-
-      # FIXME: remove
-  defp transaction,
-    do: Application.get_env(:ecto_job_scheduler, __MODULE__)[:transaction] || NewRelic.Transaction
 end
diff --git a/lib/new_relic/transaction.ex b/lib/new_relic/transaction.ex
diff --git a/test/job_queue_test.exs b/test/job_queue_test.exs
@@ -17,8 +17,6 @@ defmodule EctoJobScheduler.JobQueueTest do
           ReporterMock
           |> Mox.expect(:start, fn -> :ok end)
           |> Mox.expect(:add_attributes, fn _ -> :ok end)
-
-          Mox.expect(TransactionMock, :stop_transaction, fn -> :ok end)
         end
 
         %{}

diff --git a/test/mocks.ex b/test/mocks.ex
@@ -1,2 +1 @@
 Mox.defmock(ReporterMock, for: EctoJobScheduler.NewRelic.Reporter)
-Mox.defmock(TransactionMock, for: EctoJobScheduler.NewRelic.TransactionBehaviour)
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1 @@
		Mox.defmock(ReporterMock, for: EctoJobScheduler.NewRelic.Reporter)
		Mox.defmock(TransactionMock, for: EctoJobScheduler.NewRelic.TransactionBehaviour)