Fix thread unit tests #268

kannibalox · 2024-12-06T17:45:34Z

Convert m_poking back to a bool due to test_and_set having different return values than compare_exchange. Without this test_thread_base fails:

test_thread_base.cc:61:Assertion
Test name: test_thread_base::test_lifecycle
assertion failed
- Expression: wait_for_true(std::bind(&test_thread::is_test_state, thread, test
_thread::TEST_PRE_STOP))

test_thread_base.cc:130:Assertion
Test name: test_thread_base::test_interrupt
assertion failed
- Expression: wait_for_true(std::bind(&test_thread::is_not_test_flags, thread, 
test_thread::test_flag_do_work))

Failures !!!
Run: 27   Failure total: 2   Failures: 2   Errors: 0
FAIL: LibTorrent_Test_Torrent_Utils

The first failure is fixed by the test_thread.h change, the second by the m_poking change.

Convert m_poking back to a bool due to test_and_set having different return values than compare_exchange Also minor typo fix

kannibalox · 2024-12-06T17:53:20Z

src/torrent/utils/thread_interrupt.cc

@@ -73,6 +70,8 @@ thread_interrupt::event_read() {
    throw internal_error("Invalid result reading from thread_interrupt socket.");

  instrumentation_update(INSTRUMENTATION_POLLING_INTERRUPT_READ_EVENT, 1);
+
+  m_poking = false;


I didn't dig into exactly why, but moving this back down is indeed required for the tests to succeed.

Fix thread unit tests

04ab461

Convert m_poking back to a bool due to test_and_set having different return values than compare_exchange Also minor typo fix

kannibalox commented Dec 6, 2024

View reviewed changes

rakshasa merged commit d1d0445 into rakshasa:master Dec 7, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix thread unit tests #268

Fix thread unit tests #268

kannibalox commented Dec 6, 2024

kannibalox Dec 6, 2024

Fix thread unit tests #268

Fix thread unit tests #268

Conversation

kannibalox commented Dec 6, 2024

kannibalox Dec 6, 2024

Choose a reason for hiding this comment