some clang-tidy #309
Open
some clang-tidy #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can avoid the lambdas by using operator==. Also converted some to for range loops where it made sense. Signed-off-by: Rosen Penev <[email protected]>
Found with modernize-min-max-use-initializer-list Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -85,7 +85,7 @@ Chunk::at_position(uint32_t pos, iterator itr) { | |||
|
|
|||
| inline Chunk::iterator | |||
There was a problem hiding this comment.
Chunk is not a class, namespace, or enumeration
| @@ -85,7 +85,7 @@ Chunk::at_position(uint32_t pos, iterator itr) { | |||
|
|
|||
| inline Chunk::iterator | |||
| Chunk::find_address(void* ptr) { | |||
There was a problem hiding this comment.
Chunk is not a class, namespace, or enumeration
|
Again these are not changes that materially improve the code, and in some places actually makes it more obtuse. E.g. expanding compact if/else statements to multiple lines and adding operators to Chunks when the explicit member function call is more descriptive. There are lots of places where effort to clean up the code would be greatly appreciated, but these changes are not the right ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.