treewide: default/delete constructors #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves to modern C++11 standards. Deleted functions should be public. Signed-off-by: Rosen Penev <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| uint32_t m_chunkSize; | ||
| int m_prot; | ||
| uint32_t m_chunkSize{}; | ||
| int m_prot{~0}; | ||
| }; | ||
|
|
||
| inline Chunk::iterator |
There was a problem hiding this comment.
Chunk is not a class, namespace, or enumeration
| ~partial_queue() { disable(); } | ||
| partial_queue(const partial_queue&) = delete; | ||
| partial_queue& operator=(const partial_queue&) = delete; | ||
|
|
||
| bool is_full() const { return m_ceiling == 0; } | ||
| bool is_layer_full(size_type l) const { return m_layers[l].second >= m_maxLayerSize; } |
There was a problem hiding this comment.
invalid case style for private member m_maxLayerSize
Suggested change
| bool is_layer_full(size_type l) const { return m_layers[l].second >= m_maxLayerSize; } | |
| bool is_layer_full(size_type l) const { return m_layers[l].second >= m_max_layer_size; } |
| mapped_type* m_data; | ||
| size_type m_maxLayerSize; | ||
| mapped_type* m_data{}; | ||
| size_type m_maxLayerSize{}; |
There was a problem hiding this comment.
invalid case style for private member m_maxLayerSize
Suggested change
| size_type m_maxLayerSize{}; | |
| size_type m_max_layer_size{}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves to modern C++11 standards. Deleted functions should be public.