Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress nginx v1.12.0 #152

Open
wants to merge 6 commits into
base: nginx-1.12.x-fix
Choose a base branch
from

Conversation

krunalhinguu
Copy link

@krunalhinguu krunalhinguu commented Jan 3, 2025

ryansann and others added 6 commits January 3, 2025 15:21
* refactor rancher build process due to upstream changes
* Remove drone
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo.
This is making the drone build fail for arm64 arch. The ginkgo library
gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images
which typically install go libraries under $GOPATH/bin. Since the previously mentioned
dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH
to fix the build failure. See upstream PRs linked below for more info:
kubernetes#8566
kubernetes#8569
@krunalhinguu krunalhinguu deleted the branch rancher:nginx-1.12.x-fix January 4, 2025 00:19
@krunalhinguu krunalhinguu reopened this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants