-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update connected namespaces in storage on switch account #984
Merged
yeager-eren
merged 1 commit into
next
from
fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account
Jan 26, 2025
Merged
fix: update connected namespaces in storage on switch account #984
yeager-eren
merged 1 commit into
next
from
fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account
Jan 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyukTheCoder
requested review from
mikasackermn
and removed request for
yeager-eren
January 8, 2025 09:28
RyukTheCoder
force-pushed
the
fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account
branch
from
January 13, 2025 06:51
5310f04
to
210680f
Compare
RyukTheCoder
force-pushed
the
fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account
branch
from
January 13, 2025 07:28
210680f
to
e86ab98
Compare
yeager-eren
reviewed
Jan 20, 2025
yeager-eren
requested changes
Jan 20, 2025
yeager-eren
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
RyukTheCoder
force-pushed
the
fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account
branch
from
January 26, 2025 09:18
2f1ae1f
to
ef825da
Compare
yeager-eren
deleted the
fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account
branch
January 26, 2025 15:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two bugs:
Update connected namespaces for wallets in storage on switch account
Fixes # (RF-2098)
How did you test this change?
Tested this change by connecting phantom wallet on solana namespace. Observed that solana namespace is set in local storage in
hub-v1-last-connected-wallets
for phantom wallet. After that I switch to an account which only contains ethereum address and observed that local storage updated as result of disconnecting wallet.Checklist: