Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update connected namespaces in storage on switch account #984

Conversation

RyukTheCoder
Copy link
Collaborator

@RyukTheCoder RyukTheCoder commented Jan 7, 2025

Summary

Fixed two bugs:

Update connected namespaces for wallets in storage on switch account

Fixes # (RF-2098)

How did you test this change?

Tested this change by connecting phantom wallet on solana namespace. Observed that solana namespace is set in local storage in hub-v1-last-connected-wallets for phantom wallet. After that I switch to an account which only contains ethereum address and observed that local storage updated as result of disconnecting wallet.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@RyukTheCoder RyukTheCoder requested review from mikasackermn and removed request for yeager-eren January 8, 2025 09:28
@RyukTheCoder RyukTheCoder force-pushed the fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account branch from 5310f04 to 210680f Compare January 13, 2025 06:51
@RyukTheCoder RyukTheCoder force-pushed the fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account branch from 210680f to e86ab98 Compare January 13, 2025 07:28
Copy link
Collaborator

@yeager-eren yeager-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RyukTheCoder RyukTheCoder force-pushed the fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account branch from 2f1ae1f to ef825da Compare January 26, 2025 09:18
@yeager-eren yeager-eren merged commit 782ec1d into next Jan 26, 2025
5 checks passed
@yeager-eren yeager-eren deleted the fix/rf-2098-update-connected-namespaces-in-storage-on-switch-account branch January 26, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants