Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin build improvements #406

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Darwin build improvements #406

merged 4 commits into from
Sep 25, 2024

Conversation

Torrekie
Copy link
Contributor

Changes:

  • Handle "ios" as host/target
  • Avoid ELF-specific things on Darwin
  • Explicitly set -fexceptions
  • Avoid defining _FORTIFY_SOURCE

Fixes:

  • -Wl,--gc-sections may accidentally included to ldflags when building for Darwin

ranisalt
ranisalt reviewed May 22, 2024
View reviewed changes
binding.gyp Outdated Show resolved Hide resolved
ranisalt
ranisalt reviewed May 22, 2024
View reviewed changes
binding.gyp Outdated Show resolved Hide resolved
@ranisalt ranisalt merged commit f37b734 into ranisalt:master Sep 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranisalt ranisalt ranisalt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Torrekie @ranisalt