-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify building and testing configs #69
Closed
jameslamb
wants to merge
8
commits into
rapidsai:branch-25.02
from
jameslamb:packaging-simplification
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
793c2ec
simplify building and testing configs
jameslamb ec09d25
remove notebook-testing scripts
jameslamb bc89194
revert accidental CUDA change
jameslamb e81e738
remove git script too
jameslamb 14482d3
fix intersphinx mapping
jameslamb b871f5b
add libcugraph
jameslamb 2aa832f
empty commit to re-trigger CI
jameslamb f4972aa
new year, new copyrights
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,14 @@ | ||
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners | ||
# Order matters - match of highest importance goes last (last match wins) | ||
|
||
#doc code owners | ||
datasets/ @rapidsai/cugraph-doc-codeowners | ||
notebooks/ @rapidsai/cugraph-doc-codeowners | ||
# doc code owners | ||
docs/ @rapidsai/cugraph-doc-codeowners | ||
**/*.txt @rapidsai/cugraph-doc-codeowners | ||
**/*.md @rapidsai/cugraph-doc-codeowners | ||
**/*.rst @rapidsai/cugraph-doc-codeowners | ||
**/*.ipynb @rapidsai/cugraph-doc-codeowners | ||
**/*.pdf @rapidsai/cugraph-doc-codeowners | ||
**/*.png @rapidsai/cugraph-doc-codeowners | ||
|
||
|
||
#CI code owners | ||
# CI code owners | ||
/.github/ @rapidsai/ci-codeowners | ||
/ci/ @rapidsai/ci-codeowners | ||
/.pre-commit-config.yaml @rapidsai/ci-codeowners |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to just being simpler, consolidating into a single
conda env create
like this has some benefits for correctness and test coverage. See rapidsai/build-planning#22.