Template Conda recipe's requirements/host
#1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in build dependencies from `pyproject.toml` into Conda's `meta.yaml`.
jakirkham
added
improvement
pentschev
reviewed
Jan 20, 2025
| @@ -29,8 +29,9 @@ requirements: | |||
| host: | |||
| - python | |||
| - pip | |||
| - rapids-build-backend>=0.3.0,<0.4.0.dev0 | |||
| - setuptools>=64.0.0 | |||
| {% for r in data["build-system"]["requires"] %} | |||
There was a problem hiding this comment.
Where is build-system defined? Is it read from
Lines 1 to 6 in afc27f4
pentschev
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Left a question for my own understanding, but otherwise LGTM. Thanks @jakirkham .
raydouglass
approved these changes
Jan 22, 2025
|
Thanks John! |
|
/merge |
|
Thanks Peter and Ray! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in build dependencies from
pyproject.tomlinto Conda'smeta.yaml.