Skip to content

Commit

Permalink
Use pylibcudf instead of cudf._lib
Browse files Browse the repository at this point in the history
Signed-off-by: Sebastian Berg <[email protected]>
  • Loading branch information
mroeschke authored and seberg committed Dec 3, 2024
1 parent 0cd65f8 commit ce6dc46
Show file tree
Hide file tree
Showing 15 changed files with 18 additions and 15 deletions.
1 change: 1 addition & 0 deletions conda/environments/all_cuda-124_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ dependencies:
- numpy >=1.23,<3.0.0a0
- openssh
- pydata-sphinx-theme>=0.16.0
- pylibcudf==24.10.*,>=0.0.0a0
- pytest>=7.0
- python>=3.10,<3.13
- rapids-build-backend>=0.3.0,<0.4.0.dev0
Expand Down
1 change: 1 addition & 0 deletions conda/recipes/legate-dataframe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ requirements:
- cudf {{ rapids_version }} # pulls in pyarrow?
- libcudf {{ rapids_version }}
- librmm {{ rapids_version }}
- pylibcudf {{ rapids_version }}
run:
- python
# cuda-version is used to constrain __cuda
Expand Down
2 changes: 2 additions & 0 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ dependencies:
- output_types: conda
packages:
- &cudf_unsuffixed cudf==24.10.*,>=0.0.0a0
- &pylibcudf_unsuffixed pylibcudf==24.10.*,>=0.0.0a0
specific:
- output_types: [requirements, pyproject]
matrices:
Expand All @@ -196,6 +197,7 @@ dependencies:
cuda_suffixed: "true"
packages:
- cudf-cu12==24.10.*,>=0.0.0a0
- pylibcudf-cu12==24.10.*,>=0.0.0a0
- {matrix: null, packages: [*cudf_unsuffixed]}

depends_on_cupy:
Expand Down
2 changes: 1 addition & 1 deletion python/legate_dataframe/lib/binaryop.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from libc.stdint cimport int32_t

from cudf._lib.pylibcudf.types cimport data_type
from pylibcudf.types cimport data_type

from legate_dataframe.lib.core.column cimport LogicalColumn, cpp_LogicalColumn
from legate_dataframe.lib.core.data_type cimport as_data_type
Expand Down
4 changes: 2 additions & 2 deletions python/legate_dataframe/lib/core/column.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ from libcpp cimport bool
from libcpp.memory cimport unique_ptr
from libcpp.string cimport string

from cudf._lib.pylibcudf.libcudf.column.column cimport column, column_view
from cudf._lib.pylibcudf.types cimport data_type
from pylibcudf.libcudf.column.column cimport column, column_view
from pylibcudf.types cimport data_type

from legate_dataframe.lib.core.legate_task cimport cpp_AutoTask
from legate_dataframe.lib.core.logical_array cimport cpp_LogicalArray
Expand Down
2 changes: 1 addition & 1 deletion python/legate_dataframe/lib/core/column.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ from libcpp.string cimport string
from libcpp.utility cimport move

from cudf._lib.column cimport Column as cudfColumn
from cudf._lib.pylibcudf.libcudf.column.column cimport column
from pylibcudf.libcudf.column.column cimport column

from legate_dataframe.lib.core.legate_task cimport get_auto_task_handle
from legate_dataframe.lib.core.logical_array cimport cpp_LogicalArray
Expand Down
2 changes: 1 addition & 1 deletion python/legate_dataframe/lib/core/data_type.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# distutils: language = c++
# cython: language_level=3

from cudf._lib.pylibcudf.types cimport data_type as cpp_cudf_type
from pylibcudf.types cimport data_type as cpp_cudf_type


cdef cpp_cudf_type as_data_type(data_type_like)
Expand Down
4 changes: 2 additions & 2 deletions python/legate_dataframe/lib/core/data_type.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
# cython: language_level=3


from cudf._lib.pylibcudf.types cimport DataType
from cudf._lib.pylibcudf.types cimport data_type as cpp_cudf_type
from cudf._lib.types cimport underlying_type_t_type_id
from pylibcudf.types cimport DataType
from pylibcudf.types cimport data_type as cpp_cudf_type

import cudf
from cudf._lib import pylibcudf
Expand Down
2 changes: 1 addition & 1 deletion python/legate_dataframe/lib/core/scalar.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from libcpp cimport bool
from libcpp.memory cimport unique_ptr

from cudf._lib.pylibcudf.libcudf.scalar.scalar cimport scalar as cudf_cpp_scalar
from pylibcudf.libcudf.scalar.scalar cimport scalar as cudf_cpp_scalar


cdef extern from "legate.h" nogil:
Expand Down
4 changes: 2 additions & 2 deletions python/legate_dataframe/lib/groupby_aggregation.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
from libcpp.string cimport string
from libcpp.vector cimport vector

from cudf._lib.pylibcudf.aggregation cimport aggregation as cudf_agg
from pylibcudf.aggregation cimport aggregation as cudf_agg

from legate_dataframe.lib.core.table cimport LogicalTable, cpp_LogicalTable

from typing import Iterable, Tuple

from cudf._lib.pylibcudf.libcudf.aggregation import Kind as AggregationKind
from pylibcudf.libcudf.aggregation import Kind as AggregationKind

from legate_dataframe.utils import _track_provenance

Expand Down
2 changes: 1 addition & 1 deletion python/legate_dataframe/lib/timestamps.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from libc.stdint cimport int32_t
from libcpp.string cimport string

from cudf._lib.pylibcudf.types cimport data_type
from pylibcudf.types cimport data_type

from legate_dataframe.lib.core.column cimport LogicalColumn, cpp_LogicalColumn
from legate_dataframe.lib.core.data_type cimport as_data_type
Expand Down
2 changes: 1 addition & 1 deletion python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ requires = [

[tool.scikit-build.metadata.version]
provider = "scikit_build_core.metadata.regex"
input = "VERSION"
input = "../VERSION"
regex = "(?P<value>.*)"

[tool.scikit-build]
Expand Down
2 changes: 1 addition & 1 deletion python/tests/test_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
import cudf
import cupy
import legate.core.types as lg_type
from cudf._lib.pylibcudf.unary import UnaryOperator
from legate.core import get_legate_runtime
from pylibcudf.unary import UnaryOperator

from legate_dataframe import LogicalColumn
from legate_dataframe.lib.unaryop import unary_operation
Expand Down
1 change: 0 additions & 1 deletion python/tests/test_timestamps.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# limitations under the License.

import cudf
import cudf._lib.binaryop
import pytest

from legate_dataframe import LogicalColumn
Expand Down
2 changes: 1 addition & 1 deletion python/tests/test_unaryop.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import cudf
import cupy
import pytest
from cudf._lib.pylibcudf.unary import UnaryOperator
from pylibcudf.unary import UnaryOperator

from legate_dataframe import LogicalColumn
from legate_dataframe.lib.unaryop import unary_operation
Expand Down

0 comments on commit ce6dc46

Please sign in to comment.