-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial devcontainers #155
base: branch-0.36
Are you sure you want to change the base?
Conversation
Co-authored-by: Peter Andreas Entschev <[email protected]>
@@ -1,7 +1,7 @@ | |||
# Dependency list for https://github.com/rapidsai/dependency-file-generator | |||
files: | |||
all: | |||
output: conda | |||
output: [conda, pyproject] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
output: [conda, pyproject] | |
output: conda |
@@ -70,7 +70,7 @@ dependencies: | |||
- fmt>=10.1.1,<11 | |||
- &gmock gmock>=1.13.0 | |||
- >est gtest>=1.13.0 | |||
- librmm==24.2.* | |||
- librmm==24.02.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- librmm==24.02.* | |
- librmm==24.2.* |
# we need --pre for rmm 24.2, as all current versions are pre-release (alpha) | ||
- --pre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to handle this with something like cudf's use of alpha_spec
in a script: https://github.com/rapidsai/cudf/blob/6abef4a4746f1f9917711f372726023efdc21e85/ci/build_wheel.sh#L28-L35
@@ -160,7 +182,7 @@ dependencies: | |||
common: | |||
- output_types: [conda, requirements, pyproject] | |||
packages: | |||
- numpy>=1.21 | |||
- numpy>=1.21,<1.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's diagnose the root cause for this upper bound before merging.
This is working towards building wheels, but it has benefits for making development more unified with other RAPIDS projects.
At time of writing, this PR is not enough to get wheels working. In particular, there are some annoying issues to resolve:
As a hacky workaround just to try to get a wheel built, I changed pyproject.toml manually for a cuda 12 build. This is part of the "DO NOT MERGE" commit. This change would affect or break the conda build, so it should not go in. This file needs to be generated during build, not committed with changes.
Even with the pyproject.toml changes, we have a cmake build error:
Paul says "Looks like it's added a path to the build dir in its public interface." I don't know what that means, but I think the next step is debugging in CMakeLists.txt.