Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): apply clippy suggestion #765

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/page_handlers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ pub async fn process_handler(socket_send: &mut SocketSend, data_recv: &mut RecvC
tokio::select! {
biased;
data = data_recv.recv() => match data {
Some(Some(RequestTypes::Cmd { cmd, args: Some(args) })) => handle_error!(process_handler_helper(&cmd, args.get(0).map(String::as_str))),
Some(Some(RequestTypes::Cmd { cmd, args: Some(args) })) => handle_error!(process_handler_helper(&cmd, args.first().map(String::as_str))),
Some(Some(_)) => {}
_ => return false,
},
Expand Down Expand Up @@ -232,7 +232,7 @@ pub async fn service_handler(socket_send: &mut SocketSend, data_recv: &mut RecvC
args: Some(args),
} = data
{
if let Some(arg) = args.get(0) {
if let Some(arg) = args.first() {
handle_error!(Command::new("systemctl")
.args([&cmd, arg])
.spawn()
Expand Down Expand Up @@ -270,7 +270,7 @@ async fn browser_handler_helper(cmd: &str, args: &[String]) -> anyhow::Result<sh

tracing::debug!("Command is {}", cmd);

if let Some(arg) = args.get(0) {
if let Some(arg) = args.first() {
match cmd {
"cd" => {
return Ok(shared::BrowserList {
Expand Down
1 change: 1 addition & 0 deletions src/socket_handlers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ fn validate_token(token: &str, fingerprint: Option<&str>) -> TokenState {
}

#[instrument(skip_all)]
#[allow(clippy::no_effect_underscore_binding)]
pub async fn socket_handler(
socket: tokio_tungstenite::WebSocketStream<hyper::upgrade::Upgraded>,
fingerprint: Option<String>,
Expand Down