Feature/add env file #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namoray
reviewed
Dec 23, 2024
namoray
reviewed
Dec 23, 2024
namoray
reviewed
Dec 23, 2024
namoray
reviewed
Dec 23, 2024
namoray
reviewed
Dec 23, 2024
| @@ -54,9 +62,8 @@ if [[ -n "$NVIDIA_RUNTIME_FLAG" ]]; then | |||
| fi | |||
|
|
|||
| if [[ -n "$DEVICE" ]]; then | |||
| DOCKER_RUN_FLAGS+=" -e CUDA_VISIBLE_DEVICES=$DEVICE \ | |||
There was a problem hiding this comment.
why not cuda visible devices? are you sure this wont impact all the other containers which use 0 by default for example?
There was a problem hiding this comment.
we were using duplicate parameters that do the same thing : DEVICE & CUDA_VISIBLE_DEVICES, i removed the usage of CUDA_VISIBLE_DEVICES everywhere in the code and now using DEVICE directly
namoray
reviewed
Dec 23, 2024
| if cuda_visible_devices is not None: | ||
| gpus = cuda_visible_devices | ||
| else: | ||
| gpus = "all" | ||
|
|
||
| docker_run_flags = f"--gpus {gpus} --runtime=nvidia" | ||
| docker_run_flags = f'--gpus "device={gpus}" --runtime=nvidia' |
There was a problem hiding this comment.
wont this affect image server?
There was a problem hiding this comment.
nowp, tested using --gpus "device=0,1"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.