Skip to content

Commit

Permalink
Merge pull request #260 from razorpay/release/2.0.5
Browse files Browse the repository at this point in the history
Release/2.0.5
  • Loading branch information
Nemo authored Dec 8, 2021
2 parents 0ef7a8a + 1f71869 commit 426ad49
Show file tree
Hide file tree
Showing 11 changed files with 82 additions and 25 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED][unreleased]

## [2.0.5][2.0.5]
## Changed
- Updated Metadata

## [2.0.4][2.0.4]
## Changed
- Update IFSC.json for the below 20 IFSC codes
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ This is part of the IFSC toolset released by Razorpay.
You can find more details about the entire release at
[ifsc.razorpay.com](https://ifsc.razorpay.com).

[![](https://images.microbadger.com/badges/image/razorpay/ifsc:2.0.4.svg)](https://microbadger.com/images/razorpay/ifsc:2.0.4) [![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](https://opensource.org/licenses/MIT) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat-square)](http://makeapullrequest.com)
[![](https://images.microbadger.com/badges/image/razorpay/ifsc:2.0.5.svg)](https://microbadger.com/images/razorpay/ifsc:2.0.5) [![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](https://opensource.org/licenses/MIT) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat-square)](http://makeapullrequest.com)

[![](https://images.microbadger.com/badges/version/razorpay/ifsc:2.0.4.svg)](https://microbadger.com/images/razorpay/ifsc:2.0.4) [![npm version](https://badge.fury.io/js/ifsc.svg)](https://badge.fury.io/js/ifsc) [![Gem Version](https://badge.fury.io/rb/ifsc.svg)](https://badge.fury.io/rb/ifsc) [![PHP version](https://badge.fury.io/ph/razorpay%2Fifsc.svg)](https://badge.fury.io/ph/razorpay%2Fifsc) [![Hex pm](http://img.shields.io/hexpm/v/ifsc.svg)](https://hex.pm/packages/ifsc)
[![](https://images.microbadger.com/badges/version/razorpay/ifsc:2.0.5.svg)](https://microbadger.com/images/razorpay/ifsc:2.0.5) [![npm version](https://badge.fury.io/js/ifsc.svg)](https://badge.fury.io/js/ifsc) [![Gem Version](https://badge.fury.io/rb/ifsc.svg)](https://badge.fury.io/rb/ifsc) [![PHP version](https://badge.fury.io/ph/razorpay%2Fifsc.svg)](https://badge.fury.io/ph/razorpay%2Fifsc) [![Hex pm](http://img.shields.io/hexpm/v/ifsc.svg)](https://hex.pm/packages/ifsc)

## Dataset

Expand Down
4 changes: 2 additions & 2 deletions ifsc.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)

Gem::Specification.new do |s|
s.name = 'ifsc'
s.version = '2.0.4'
s.date = '2021-11-18'
s.version = '2.0.5'
s.date = '2021-12-08'
s.summary = 'IFSC code database to help you validate IFSC codes'
s.description = 'A simple gem by @razorpay to help you validate your IFSC codes. IFSC codes are bank codes within India'
s.authors = ['Abhay Rana', 'Nihal Gonsalves']
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ifsc",
"version": "2.0.4",
"version": "2.0.5",
"description": "This is part of the IFSC toolset released by Razorpay. You can find more details about the entire release at [ifsc.razorpay.com](https://ifsc.razorpay.com). Includes only a validation library as of now.",
"main": "src/node/index.js",
"directories": {
Expand Down
5 changes: 4 additions & 1 deletion scraper/scripts/methods_nach.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,12 @@ def parse_upi
count = doc.css('table>tbody')[0].css('tr').map{|e| e.css('td')[1].text.strip}.uniq.size

upi_patch_filename = '../../src/patches/banks/upi-enabled-banks.yml'
upi_branch_patch_filename = '../../src/patches/ifsc/upi-enabled-branches.yml'

# Count the number of banks we have in our UPI patch file:
data = YAML.safe_load(File.read(upi_patch_filename), [Symbol])
if data['banks'].size != count
branch_data = YAML.safe_load(File.read(upi_branch_patch_filename), [Symbol])
if data['banks'].size + branch_data['ifsc'].size != count
log "Number of UPI-enabled banks (#{data['banks'].size}) does not match the count on the NPCI website (#{count})}", :critical
log "Please check https://www.npci.org.in/what-we-do/upi/live-members and update src/patches/banks/upi-enabled-banks.yml", :debug
exit 1
Expand Down
2 changes: 1 addition & 1 deletion src/IFSC.json

Large diffs are not rendered by default.

42 changes: 27 additions & 15 deletions src/banks.json
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"AGDX": {
"code": "AGDX",
Expand Down Expand Up @@ -346,7 +347,8 @@
"apbs": false,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"AJPX": {
"code": "AJPX",
Expand Down Expand Up @@ -2477,7 +2479,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"CMCX": {
"code": "CMCX",
Expand Down Expand Up @@ -3275,7 +3278,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"DNDC": {
"code": "DNDC",
Expand Down Expand Up @@ -3797,7 +3801,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"GCBX": {
"code": "GCBX",
Expand Down Expand Up @@ -4741,8 +4746,7 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": true,
"upi": true
"nach_debit": true
},
"JANA": {
"code": "JANA",
Expand Down Expand Up @@ -5786,7 +5790,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"JUSX": {
"code": "JUSX",
Expand Down Expand Up @@ -8294,7 +8299,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"NAWX": {
"code": "NAWX",
Expand Down Expand Up @@ -8505,7 +8511,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"NGNX": {
"code": "NGNX",
Expand Down Expand Up @@ -12033,7 +12040,8 @@
"apbs": false,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"STCB": {
"code": "STCB",
Expand Down Expand Up @@ -12742,7 +12750,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"TFCX": {
"code": "TFCX",
Expand Down Expand Up @@ -13276,7 +13285,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"TOCX": {
"code": "TOCX",
Expand Down Expand Up @@ -14125,7 +14135,8 @@
"apbs": true,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"VANX": {
"code": "VANX",
Expand Down Expand Up @@ -14518,7 +14529,8 @@
"apbs": false,
"ach_credit": true,
"ach_debit": true,
"nach_debit": false
"nach_debit": false,
"upi": true
},
"VSVX": {
"code": "VSVX",
Expand Down
2 changes: 2 additions & 0 deletions src/custom-sublets.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
"APBL0013023": "DCKX",
"FDRL0SAWANT": "Sawantwadi Urban Co-operative Bank",
"FDRL0SPCB01": "Sreenivasa Padmavathi Co-operative Bank",
"HDFC0CHB1": "HCBL",
"ICIC00TJUCB": "Jamkhandi Urban Co-operative Bank",
"JAKA0GRAMEN": "XJKG",
"JAKA0JKBCCB": "Baramulla Central Co-operative Bank",
"KJSB0KUB2": "Konark Urban Co-operative Bank",
Expand Down
20 changes: 18 additions & 2 deletions src/patches/banks/upi-enabled-banks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
# Last Updated: Nov 2021 (Count = 259)
# Keep all confusing changes at the bottom of this file, to
# keep this sorted
#
# In case the bank doesn't have a code of it's own, find the corresponding
# IFSC and use it. Make sure the IFSC is reflected in the src/custom-sublets.json
# file as well
action: patch
patch:
:upi: true
Expand All @@ -15,8 +19,10 @@ banks:
- ACUX
- ADBX
- ADCC
- AGCX
- AGVX
- AIRP
- AJNX
- AJPX
- AMCB
- AMDN
Expand Down Expand Up @@ -51,6 +57,7 @@ banks:
- CIUB
- CJMX
- CLBL
- CMCB
- CNRB
- COLX
- COMX
Expand All @@ -69,13 +76,15 @@ banks:
- DGBX
- DHUX
- DLXB
- DMKB
- DNSB
- ESFB
- ESMF
- FDRL
- FGCB
- FINO
- FSFB
- GBCB
- GCUX
- GDCB
- GDUX
Expand Down Expand Up @@ -107,6 +116,7 @@ banks:
- JSBL
- JSBP
- JSFB
- JUCX
- JVCX
- KAIJ
- KARB
Expand Down Expand Up @@ -154,8 +164,10 @@ banks:
- MUSX
- MVIX
- MZRX
- NAVX
- NBMX
- NESF
- NGKX
- NKGS
- NMCX
- NNSB
Expand Down Expand Up @@ -216,6 +228,7 @@ banks:
- SRCB
- SRHX
- SSDX
- SSWX
- STCB
- STRX
- SUBX
Expand All @@ -233,12 +246,14 @@ banks:
- TBSB
- TCBX
- TECX
- TETX
- TGBX
- TGNX
- TJSB
- TKCX
- TMBL
- TMSX
- TNUX
- TSAB
- TSUX
- TUCX
Expand All @@ -252,6 +267,7 @@ banks:
- UTIB
- UTKS
- UUCX
- VAIX
- VANX
- VARA
- VCCX
Expand All @@ -260,6 +276,7 @@ banks:
- VISX
- VSBL
- VSCX
- VSSX
- VVCX
- VVSB
- XJKG
Expand All @@ -269,5 +286,4 @@ banks:
# There is some confusion regarding this
# This is HASTI Bank here
- HCBL
# Made up code for jamkhandi urban co-operative bank
- JAMX
# See ifsc/upi-enabled-branches.yml for a "branch-specific version"
20 changes: 20 additions & 0 deletions src/patches/ifsc/upi-enabled-branches.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
# Source: https://www.npci.org.in/what-we-do/upi/live-members
# Remember to take a snapshot at https://web.archive.org/save
# when you make changes to this file
# Last Updated: Dec 2021 (Count = 271 + 2 = 273)
# This file only contains "banks with custom sublets" who do not have
# their own IFSC code. This is quite rare, but happens ocassionally.
# In one specific case, MDCB0680265 support UPI, but the parent bank
# MDCB does not. So separating this way ensures that the UPI: true
# flag is only enabled for the relevant branches, and not the whole
# bank.
action: patch
patch:
:upi: true
ifsc:
# jamkhandi urban co-operative bank
- ICIC00TJUCB
# https://pratapbank.in/imps.php
# Pratap Co-operative Bank
- MDCB0680265

0 comments on commit 426ad49

Please sign in to comment.