Bank constants for nodejs (#165)

Bank constants for nodejs

CHANGELOG.md

@@ -4,35 +4,42 @@ All notable changes to this project will be documented in this file. The format
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## UNRELEASED
+
 ### Added
-- Adds offline bank details fetch method in ruby.
-- Adds support for `upi: true` flag in `banks.json`
-- Adds `UPI: true/false` flag in `IFSC.csv` and `by-banks` JSON files
+
+-   Adds bank constants in nodejs
+-   Adds offline bank details fetch method in ruby.
+-   Adds support for `upi: true` flag in `banks.json`
+-   Adds `UPI: true/false` flag in `IFSC.csv` and `by-banks` JSON files
 
 ### Changed
-- Improves coverage of bank constants in ruby.
+
+-   Improves coverage of bank constants in ruby.
 
 ## [1.4.10][1.4.10] - 2020-01-02
-- Metadata Updates
-- Support for patches that can override data for specific IFSC codes
-- NEFT Block for certain banks:
-    + Bank Of Ceylon
-    + Krung Thai Bank
-    + Kaveri Grameena Bank
-    + Kerala Gramin Bank
-    + Pragathi Krishna Gramin Bank
-    + Sbm Bank Mauritius Ltd
+
+-   Metadata Updates
+-   Support for patches that can override data for specific IFSC codes
+-   NEFT Block for certain banks:
+    -   Bank Of Ceylon
+    -   Krung Thai Bank
+    -   Kaveri Grameena Bank
+    -   Kerala Gramin Bank
+    -   Pragathi Krishna Gramin Bank
+    -   Sbm Bank Mauritius Ltd
 
 ## [1.4.9][1.4.8] - 2019-11-07
-- Metadata Updates
+
+-   Metadata Updates
 
 ## [1.4.7][1.4.7] - 2019-10-14
-- Minor Metadata updates
+
+-   Minor Metadata updates
 
 ## [1.4.6][1.4.6] - 2019-09-05
 
-- Metadata updates
-- Catholic Syrian Bank is renamed to CSB Bank
+-   Metadata updates
+-   Catholic Syrian Bank is renamed to CSB Bank
 
 ## [1.4.5][1.4.5] - 2019-07-15
 
@@ -85,7 +92,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 -   Removes some data formats (YAML/Large JSON) for cleaner code. If you were using them, please let create an issue.
 
 [unreleased]: https://github.com/razorpay/ifsc/compare/1.4.9...HEAD
-
 [1.4.10]: https://github.com/razorpay/ifsc/releases/tag/1.4.10
 [1.4.9]: https://github.com/razorpay/ifsc/releases/tag/1.4.9
 [1.4.8]: https://github.com/razorpay/ifsc/releases/tag/1.4.8

LICENSE

@@ -1,5 +1,5 @@
 The MIT License (MIT)
-Copyright (c) 2019 Razorpay
+Copyright (c) 2020 Razorpay
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 

README.md

@@ -21,9 +21,9 @@ with the complete dataset as well.
 
 The source for the dataset are the following files:
 
-- List of NEFT IFSCs from [RBI website][combined]
-- List of RTGS IFSCs from [RBI website][rtgs]
-- List of ACH Live Banks from [NPCI website][ach] used for IFSC sublet branches
+-  List of NEFT IFSCs from [RBI website][combined]
+-  List of RTGS IFSCs from [RBI website][rtgs]
+-  List of ACH Live Banks from [NPCI website][ach] used for IFSC sublet branches
 
 ## Installation
 
@@ -61,7 +61,7 @@ require "ifsc"
 
 The PHP package has a dependency on the virtual package `php-http/client-implementation` which requires you to install an adapter, but we do not care which one. That is an implementation detail in your application. You do not have to use the `php-http/curl-client` if you do not want to. You may use the `php-http/guzzle6-adapter`. Read more about the virtual packages, why this is a good idea and about the flexibility it brings at the [HTTPlug docs](http://docs.php-http.org/en/latest/httplug/users.html). You can find a list of suported providers on [packagist](https://packagist.org/providers/php-http/client-implementation).
 
-The minimum [PHP version supported is 7.1](https://endoflife.date/php).
+The minimum [PHP version supported is 7.2](https://endoflife.date/php).
 
 ## Node.js
 
@@ -76,7 +76,7 @@ Only the latest version of each SDK is considered.
 | PHP      | ✅         | ✅         | ✅ (✅)                 | ✅             |
 | Ruby     | ✅         | ✅         | ✅ (✅)                 | ✅             |
 | Elixir   | ✅         | ✅         | ✅ (❎)                 | ❎             |
-| Node.js  | ✅         | ✅         | ❎ (❎)                 | ❎             |
+| Node.js  | ✅         | ✅         | ❎ (❎)                 | ✅             |
 
 ## API Documentation
 
@@ -151,6 +151,8 @@ ifsc.validate('BOTM0XEEMRA'); // returns false
 ifsc.fetchDetails('KKBK0000261').then(function(res) {
    console.log(res);
 });
+
+console.log(ifsc.bank.PUNB); // prints PUNB
 // Prints the entire JSON from https://ifsc.razorpay.com/KKBK0000261
 // res is an object, not string
 ```
@@ -189,6 +191,11 @@ Razorpay::IFSC::Bank.get_details 'PUNB'
    ach_debit: true,
    nach_debit: true
 }
+
+# constants
+
+Razorpay::IFSC::Bank::PUNB
+'PUNB'
 ```
 
 Validate online and retrieve details from the server

package.json

@@ -11,7 +11,7 @@
   },
   "devDependencies": {},
   "scripts": {
-    "test": "node tests/node/validator_test.js && node tests/node/client_test.js"
+    "test": "node tests/node/validator_test.js && node tests/node/client_test.js && node tests/node/bank_test.js"
   },
   "repository": {
     "type": "git",