Skip to content

Commit

Permalink
added some new banks
Browse files Browse the repository at this point in the history
  • Loading branch information
Patlola committed Jul 8, 2020
1 parent 196c17d commit 8aa86e0
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scraper/scripts/methods.rb
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def parse_rtgs(banks)

# There is a second header in the middle of the sheet.
# :facepalm: RBI
next if row['IFSC'].nil? or ['IFSC_CODE', 'BANK OF BARODA', ''].include?(row['IFSC'])
next if row['IFSC'].nil? or ['IFSC_CODE', 'BANK OF BARODA', '', 'KPK HYDERABAD'].include?(row['IFSC'])

original_ifsc = row['IFSC']
row['IFSC'] = row['IFSC'].upcase.gsub(/[^0-9A-Za-z]/, '').strip
Expand Down
3 changes: 3 additions & 0 deletions src/banknames.json
Original file line number Diff line number Diff line change
Expand Up @@ -997,6 +997,7 @@
"RSBL": "Rajgurunagar Sahakari Bank",
"RSBX": "Raigad Sahakari Bank",
"RSCB": "Rajasthan State Co-operative Bank",
"RSSB": "Rajarshi Shahu Sahakari Bank",
"RSSX": "Rajarshi Shahu Sahakari Bank",
"RSUX": "Radhasoami Urban Co-operative Bank",
"RSVX": "Rajarshi Shahu Govt Servants Co-operative Bank Kolh",
Expand Down Expand Up @@ -1169,6 +1170,7 @@
"SUNB": "Surat National Co-operative Bank",
"SURX": "Siddheshwar Urban Co-operative Bank Maryadit Sillod",
"SURY": "Suryoday Small Finance Bank",
"SUSB": "Suco Souharda Sahakari Bank",
"SUSX": "Sirsi Urban Sahakari Bank",
"SUTB": "Sutex Co-operative Bank",
"SUVX": "Suvarnayug Sahakari Bank",
Expand Down Expand Up @@ -1346,6 +1348,7 @@
"UTKS": "Utkarsh Small Finance Bank",
"UTKX": "Uttarakhand State Co-operative Bank",
"UTZX": "Uttarkashi Zila Sahkari Bank",
"UUCB": "Udaipur Urban Co-operative Bank",
"UUCX": "Udaipur Urban Co-operative Bank",
"VADX": "Valsad District Central Co-operative Bank",
"VAIX": "Vaishya Sahakari Bank Mumbai",
Expand Down
3 changes: 3 additions & 0 deletions src/php/Bank.php
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,7 @@ class Bank
const RSBL = 'RSBL';
const RSBX = 'RSBX';
const RSCB = 'RSCB';
const RSSB = 'RSSB';
const RSSX = 'RSSX';
const RSUX = 'RSUX';
const RSVX = 'RSVX';
Expand Down Expand Up @@ -1173,6 +1174,7 @@ class Bank
const SUNB = 'SUNB';
const SURX = 'SURX';
const SURY = 'SURY';
const SUSB = 'SUSB';
const SUSX = 'SUSX';
const SUTB = 'SUTB';
const SUVX = 'SUVX';
Expand Down Expand Up @@ -1350,6 +1352,7 @@ class Bank
const UTKS = 'UTKS';
const UTKX = 'UTKX';
const UTZX = 'UTZX';
const UUCB = 'UUCB';
const UUCX = 'UUCX';
const VADX = 'VADX';
const VAIX = 'VAIX';
Expand Down
4 changes: 4 additions & 0 deletions src/ruby/bank.rb
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,7 @@ module Bank
KATX = :KATX
KAYX = :KAYX
KBCX = :KBCX
KBKB = :KBKB
KBNX = :KBNX
KBSX = :KBSX
KCBL = :KCBL
Expand Down Expand Up @@ -999,6 +1000,7 @@ module Bank
RSBL = :RSBL
RSBX = :RSBX
RSCB = :RSCB
RSSB = :RSSB
RSSX = :RSSX
RSUX = :RSUX
RSVX = :RSVX
Expand Down Expand Up @@ -1171,6 +1173,7 @@ module Bank
SUNB = :SUNB
SURX = :SURX
SURY = :SURY
SUSB = :SUSB
SUSX = :SUSX
SUTB = :SUTB
SUVX = :SUVX
Expand Down Expand Up @@ -1348,6 +1351,7 @@ module Bank
UTKS = :UTKS
UTKX = :UTKX
UTZX = :UTZX
UUCB = :UUCB
UUCX = :UUCX
VADX = :VADX
VAIX = :VAIX
Expand Down
2 changes: 1 addition & 1 deletion tests/php/CoverageTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function testNames()
{
// For some reason the CSV header is picked up as a IFSC code
// Skip the check while this is fixed.
$exceptions = ['IFSC'];
$exceptions = ['IFSC', 'KPKH'];
foreach ($this->bankCodes as $code)
{
if (!in_array($code, $exceptions))
Expand Down

0 comments on commit 8aa86e0

Please sign in to comment.