Merge pull request #244 from razorpay/release/2.0.0

razorpay · Aug 31, 2021 · c940f0c · c940f0c
2 parents 4b36689 + eef3c8b
commit c940f0c
Show file tree

Hide file tree

Showing 23 changed files with 111 additions and 49 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -13,6 +13,9 @@ insert_final_newline = true
 indent_style = space
 indent_size = 4
 
-[**.js, *.json]
+[**.js, *.json, **.rb]
 indent_style = space
 indent_size = 2
+
+[*.go]
+indent_style = tab
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -0,0 +1,2 @@
+.go @gyanesh-m
+.rb @captn3m0
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -12,12 +12,6 @@ updates:
       interval: weekly
       time: "04:00"
       timezone: Asia/Calcutta
-  - package-ecosystem: mix
-    directory: "/"
-    schedule:
-      interval: weekly
-      time: "04:00"
-      timezone: Asia/Calcutta
   - package-ecosystem: composer
     directory: "/"
     schedule:

diff --git a/.github/workflows/scraper.yml b/.github/workflows/scraper.yml
@@ -47,6 +47,30 @@ jobs:
         with:
           name: release-artifact
           path: scraper/scripts/data
+      - name: Extract artifact
+        run: gunzip by-bank.tar.gz
+        working-directory: scraper/scripts/data
       - run: phpunit -d memory_limit=-1
         env:
           RUN_DATASET_TESTS: true
+  release-notes:
+    needs: scraper
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.0
+      - name: Download artifacts
+        uses: actions/download-artifact@v2
+        with:
+          name: release-artifact
+          path: scraper/scripts/data
+      - name: Run release script
+        run: bash release.sh
+        working-directory: scraper/scripts
+      - name: Save Release Notes
+        uses: actions/upload-artifact@v2
+        with:
+          name: release-notes.md
+          path: scraper/scripts/release.md
diff --git a/.gitignore b/.gitignore
@@ -41,13 +41,17 @@ mix.lock
 .yardoc
 Gemfile.lock
 InstalledFiles
-.wercker
 
 # One-off scripts
 *.php
+tmp/
+
+# Code coverage reports
+*.cov
 
 # IDE files
 .idea/*
 
 # Temp files
 .*~
+
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,11 +4,15 @@ All notable changes to this project will be documented in this file. The format
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [UNRELEASED][unreleased]
+
 ## [2.0.0][2.0.0]
 ### Removed
 - Removed support for Elixir package
 ### Changed
 - Builds are now powered by GitHub Actions, instead of Wercker
+### Added
+- There is a supported golang SDK. See the README for instructions on how to use it.
+- 1 New Bank: `"AHDC": "Ahmednagar District Central Co-operative Bank"`
 
 ## [1.6.1][1.6.1]
 ### Added

diff --git a/README.md b/README.md
@@ -84,13 +84,21 @@ The minimum [PHP version supported is 7.2](https://endoflife.date/php).
 
 ## Go
 
-`$ go get -u github.com/razorpay/ifsc`
+This package is compatible with modern Go releases in module mode, with Go installed:
 
-To use the go pkg, the import path should be:
+`go get github.com/razorpay/ifsc/v2`
 
-```go
-import "github.com/razorpay/ifsc/src/go"
-```
+will resolve and add the package to the current development module, along with its dependencies.
+
+Alternatively the same can be achieved if you use import in a package:
+
+`import "github.com/razorpay/ifsc/v2/src/go"`
+
+and run go get without parameters.
+
+Finally, to use the top-of-trunk version of this repo, use the following command:
+
+`go get github.com/razorpay/ifsc/v2@master`
 
 ## Support Matrix
 
@@ -353,7 +361,6 @@ func main() {
 
 ```
 
->>>>>>> 5ff434d (update readme & make bank code constants.)
 ### Code Notes
 
 Both the packages ship with a 300kb JSON file, that

diff --git a/go.mod b/go.mod
@@ -1,5 +1,5 @@
-module github.com/razorpay/ifsc
+module github.com/razorpay/ifsc/v2
 
-go 1.15
+go 1.16
 
 require github.com/stretchr/testify v1.7.0
diff --git a/ifsc.gemspec b/ifsc.gemspec
@@ -3,8 +3,8 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |s|
   s.name        = 'ifsc'
-  s.version     = '1.6.1'
-  s.date        = '2021-07-09'
+  s.version     = '2.0.0'
+  s.date        = '2021-08-12'
   s.summary     = 'IFSC code database to help you validate IFSC codes'
   s.description = 'A simple gem by @razorpay to help you validate your IFSC codes. IFSC codes are bank codes within India'
   s.authors     = ['Abhay Rana', 'Nihal Gonsalves']

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ifsc",
-  "version": "1.6.1",
+  "version": "2.0.0",
   "description": "This is part of the IFSC toolset released by Razorpay. You can find more details about the entire release at [ifsc.razorpay.com](https://ifsc.razorpay.com). Includes only a validation library as of now.",
   "main": "src/node/index.js",
   "directories": {

diff --git a/scraper/Gemfile.lock b/scraper/Gemfile.lock
@@ -7,14 +7,14 @@ GEM
     mime-types (3.3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2021.0704)
-    mini_portile2 (2.5.3)
+    mini_portile2 (2.6.1)
     multi_xml (0.6.0)
-    nokogiri (1.11.7)
-      mini_portile2 (~> 2.5.0)
+    nokogiri (1.12.4)
+      mini_portile2 (~> 2.6.1)
       racc (~> 1.4)
     racc (1.5.2)
     ruby-ole (1.2.12.2)
-    rubyXL (3.4.17)
+    rubyXL (3.4.18)
       nokogiri (>= 1.10.8)
       rubyzip (>= 1.3.0)
     rubyzip (2.3.2)
@@ -31,4 +31,4 @@ DEPENDENCIES
   spreadsheet
 
 BUNDLED WITH
-   2.2.22
+   2.2.26
diff --git a/scraper/scripts/methods_nach.rb b/scraper/scripts/methods_nach.rb
@@ -44,8 +44,9 @@ def bank_data(bank_code, data, _ifsc)
 
 def parse_upi
   doc = Nokogiri::HTML(open('upi.html'))
-  header_cleared = false
-  count = doc.css('table>tbody')[0].css('tr').size
+  # We count the unique number of banks mentioned in the table
+  # Since sometimes NPCI will repeat banks
+  count = doc.css('table>tbody')[0].css('tr').map{|e| e.css('td')[1].text.strip}.uniq.size
 
   upi_patch_filename = '../../src/patches/banks/upi-enabled-banks.yml'
   # Count the number of banks we have in our UPI patch file:

diff --git a/src/IFSC.json b/src/IFSC.json
diff --git a/src/banknames.json b/src/banknames.json
@@ -27,6 +27,7 @@
   "AGSX": "Agrasen Nagari Sahakari Bank",
   "AGUX": "Agartala Co-operative Urban Bank",
   "AGVX": "Assam Gramin Vikash Bank",
+  "AHDC": "Ahmednagar District Central Co-operative Bank",
   "AHMX": "Ahmednagar District Central Co-operative Bank",
   "AHUX": "Ahilyadevi Urban Co-operative Bank Limited Solapur",
   "AIRP": "Airtel Payments Bank",
@@ -1266,6 +1267,7 @@
   "TKUX": "Karan Urban Co-operative Bank",
   "TLPX": "Lunawada Peoples Co-operative Bank",
   "TMAX": "Madanapalle Co-operative Town Bank",
+  "TBMC": "Banaskantha Mercantile Co-operative Bank",
   "TMBL": "Tamilnadu Mercantile Bank",
   "TMBX": "Mangalore Catholic Co-operative Bank",
   "TMCX": "Motihari Central Co-operative Bank",

diff --git a/src/banks.json b/src/banks.json
@@ -1335,7 +1335,8 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": false,
-    "nach_debit": false
+    "nach_debit": false,
+    "upi": true
   },
   "BDIX": {
     "code": "BDIX",
@@ -1645,8 +1646,7 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": false,
-    "upi": true
+    "nach_debit": false
   },
   "BKDX": {
     "code": "BKDX",
@@ -3069,7 +3069,8 @@
     "apbs": false,
     "ach_credit": true,
     "ach_debit": false,
-    "nach_debit": false
+    "nach_debit": false,
+    "upi": true
   },
   "DIBX": {
     "code": "DIBX",
@@ -4036,7 +4037,8 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": false
+    "nach_debit": false,
+    "upi": true
   },
   "HCBX": {
     "code": "HCBX",
@@ -7084,7 +7086,8 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": false
+    "nach_debit": false,
+    "upi": true
   },
   "MBLX": {
     "code": "MBLX",
@@ -8432,7 +8435,8 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": false
+    "nach_debit": false,
+    "upi": true
   },
   "NNCX": {
     "code": "NNCX",
@@ -11308,7 +11312,8 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": false
+    "nach_debit": false,
+    "upi": true
   },
   "SNCX": {
     "code": "SNCX",
@@ -11486,7 +11491,8 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": false
+    "nach_debit": false,
+    "upi": true
   },
   "SPSX": {
     "code": "SPSX",
@@ -12018,8 +12024,7 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": true,
-    "upi": true
+    "nach_debit": true
   },
   "TACX": {
     "code": "TACX",
@@ -12641,7 +12646,8 @@
     "apbs": false,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": false
+    "nach_debit": false,
+    "upi": true
   },
   "TKDX": {
     "code": "TKDX",
@@ -13911,8 +13917,7 @@
     "apbs": true,
     "ach_credit": true,
     "ach_debit": true,
-    "nach_debit": false,
-    "upi": true
+    "nach_debit": false
   },
   "VHDX": {
     "code": "VHDX",

diff --git a/src/go/client_test.go b/src/go/client_test.go
@@ -8,7 +8,7 @@ import (
 	"net/http"
 	"testing"
 
-	"github.com/razorpay/ifsc/src/go/mocks"
+	"github.com/razorpay/ifsc/v2/src/go/mocks"
 	"github.com/stretchr/testify/assert"
 )
 

diff --git a/src/go/constants.go b/src/go/constants.go
@@ -33,6 +33,7 @@ const (
         AGSX = "AGSX"
         AGUX = "AGUX"
         AGVX = "AGVX"
+        AHDC = "AHDC"
         AHMX = "AHMX"
         AHUX = "AHUX"
         AIRP = "AIRP"
@@ -1217,6 +1218,7 @@ const (
         TBCX = "TBCX"
         TBDX = "TBDX"
         TBHX = "TBHX"
+        TBMC = "TBMC"
         TBMX = "TBMX"
         TBNS = "TBNS"
         TBPX = "TBPX"
@@ -1494,6 +1496,7 @@ var bankCodes = map[string]bool{
         "AGSX" : true, 
         "AGUX" : true, 
         "AGVX" : true, 
+        "AHDC" : true, 
         "AHMX" : true, 
         "AHUX" : true, 
         "AIRP" : true, 
@@ -2678,6 +2681,7 @@ var bankCodes = map[string]bool{
         "TBCX" : true, 
         "TBDX" : true, 
         "TBHX" : true, 
+        "TBMC" : true, 
         "TBMX" : true, 
         "TBNS" : true, 
         "TBPX" : true, 

diff --git a/src/node/bank.js b/src/node/bank.js
@@ -27,6 +27,7 @@ module.exports = Object.freeze({
   AGSX: 'AGSX',
   AGUX: 'AGUX',
   AGVX: 'AGVX',
+  AHDC: 'AHDC',
   AHMX: 'AHMX',
   AHUX: 'AHUX',
   AIRP: 'AIRP',
@@ -1212,6 +1213,7 @@ module.exports = Object.freeze({
   TBCX: 'TBCX',
   TBDX: 'TBDX',
   TBHX: 'TBHX',
+  TBMC: 'TBMC',
   TBMX: 'TBMX',
   TBNS: 'TBNS',
   TBPX: 'TBPX',