Adds ILCB to bank lists

razorpay · Dec 30, 2019 · ead204d · ead204d
1 parent b552ba6
commit ead204d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/src/banknames.json b/src/banknames.json
@@ -435,6 +435,7 @@
   "IDIB": "Indian Bank",
   "IDUK": "Idukki District Co-operative Bank",
   "IDUX": "Idukki District Co-operative Bank",
+  "ILCB": "Ilkal Co-operative Bank",
   "IMPX": "Imphal Urban Co-operative Bank",
   "INCX": "Indapur Urban Co-operative Bank",
   "INDB": "Indusind Bank",

diff --git a/src/php/Bank.php b/src/php/Bank.php
@@ -438,6 +438,7 @@ class Bank
     const IDIB = 'IDIB';
     const IDUK = 'IDUK';
     const IDUX = 'IDUX';
+    const ILCB = 'ILCB';
     const IMPX = 'IMPX';
     const INCX = 'INCX';
     const INDB = 'INDB';

diff --git a/src/ruby/bank.rb b/src/ruby/bank.rb
@@ -433,6 +433,7 @@ module Bank
       IDIB = :IDIB
       IDUK = :IDUK
       IDUX = :IDUX
+      ILCB = :ILCB
       IMPX = :IMPX
       INCX = :INCX
       INDB = :INDB

diff --git a/tests/php/CoverageTest.php b/tests/php/CoverageTest.php
@@ -174,13 +174,14 @@ public function testPatches()
 
             foreach ($yaml['ifsc'] as $code)
             {
-                if (IFSC::validate($code) !== true)
+                if (IFSC::validate($code) !== true and $yaml['action'] != 'delete')
                 {
                     $failures[] = $code;
                 }
             }
         }
 
+        // BANKOFBAROD is an invalid code, so it is marked as an exception
         $this->assertEquals([], $failures, "IFSC codes present in patches, but fails validation");
     }
 }