Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYSTEST-9607- Event error message bug fix #148

Merged
merged 10 commits into from
Dec 4, 2023
Merged

SYSTEST-9607- Event error message bug fix #148

merged 10 commits into from
Dec 4, 2023

Conversation

Nandana-NNR
Copy link
Contributor

@Nandana-NNR Nandana-NNR commented Nov 30, 2023 •
edited
Loading

Bug fix for https://ccp.sys.comcast.net/browse/SYSTEST-9607

Added

  • New unit test to validate updated error handling function and functional test update to capture updated error message

Changed

  • Refined logErr() and fErr() functions which handles event error messages to appropriately throw both event validation and event registration errors.

Fixed

  • Fixed bug related to event error message handling wherein all event errors were previously thrown as an improper generic error which was misleading to users. Implemented a mechanism to correctly distinguish different types of event errors and throw them appropriately

ksentak
ksentak reviewed Nov 30, 2023
View reviewed changes
server/src/events.mjs Outdated Show resolved Hide resolved
michaelcfine
michaelcfine requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@michaelcfine michaelcfine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments; mainly... let's definitely pass errorType in the fErr and fFatalErr calls.

server/src/events.mjs Outdated Show resolved Hide resolved
server/src/events.mjs Outdated Show resolved Hide resolved
server/src/events.mjs Outdated Show resolved Hide resolved
server/src/messageHandler.mjs Outdated Show resolved Hide resolved
server/src/routes/api/event.mjs Outdated Show resolved Hide resolved
server/src/routes/api/event.mjs Outdated Show resolved Hide resolved
ksentak
ksentak previously approved these changes Dec 1, 2023
View reviewed changes
michaelcfine
michaelcfine requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@michaelcfine michaelcfine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better; just one change I think you should make... making sure we always log at least some message even when error type is not given.

server/src/events.mjs Show resolved Hide resolved
@kschrief kschrief merged commit a1a9cc6 into rdkcentral:main Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksentak ksentak ksentak approved these changes

@kschrief kschrief kschrief approved these changes

@michaelcfine michaelcfine Awaiting requested review from michaelcfine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nandana-NNR @michaelcfine @kschrief @ksentak