Apply suggestions from code review

rdmorganiser · Jan 22, 2024 · ff2fc25 · ff2fc25
1 parent 4f66c9b
commit ff2fc25
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/rdmorganiser/questions/SMP_Readme.md b/rdmorganiser/questions/SMP_Readme.md
@@ -24,7 +24,7 @@ Furthermore, this SMP template was inspired by some documentations, specially:
 | 2.0 | 18th August 2023    | a) Addition of a question regarding Qualifty References (reference to FAIR4RS I2 and R2); b) adjustments to questions and help texts for the FAIR4RS viewer; c) minor adjustments to help texts thanks to feedback; d) broken links repair + Thanks a lot for the feedback by the RDMO Community!|
 
 # Implementing
-The catalogue uses the generic elements from RDMO. Therefore, all generic elements from "Conditions", "Domain", "Options" and "Questions" must already be implemented in advance.
+The catalogue uses the generic elements from RDMO. Therefore, all generic elements from "Conditions", "Domain", "Options" and "Questions" must already be implemented in advance. The respective order is documented in the [generic Readme file of the RDMO content](https://github.com/rdmorganiser/rdmo-catalog/tree/master/rdmorganiser#readme) and must be observed.
 
 # Transferability
 This catalogue introduces many custom attributes, as the generic RDMO attributes do not always cover the specific aspects of software. For this reason, the existing views in RDMO cannot be used for this catalogue, or only to a very limited extent.

diff --git a/rdmorganiser/questions/fhpshort.xml b/rdmorganiser/questions/fhpshort.xml
@@ -256,10 +256,10 @@
 		<order>0</order>
 		<help lang="en">Examples of discipline-specific requirements are: 
 
-- &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/antragstellung/forschungsdaten/guidelines_biodiversity_research.pdf&quot; target=&quot;_blank&quot;&gt;Guidelines on the Handling of Research Data in Biodiversity Research&lt;/a&gt;
-- &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/antragstellung/forschungsdaten/richtlinien_forschungsdaten_bildungsforschung.pdf&quot; target=&quot;_blank&quot;&gt;Guidelines for the provision and use of quantitative data in education research (German)&lt;/a&gt;
-- &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/antragstellung/forschungsdaten/foerderkriterien_editionen_literaturwissenschaft.pdf&quot; target=&quot;_blank&quot;&gt;Elegibility criteria for funding for scholarly editions in the literary studies (German)&lt;/a&gt;
-- Recommendations on &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/grundlagen_dfg_foerderung/informationen_fachwissenschaften/geisteswissenschaften/standards_sprachkorpora.pdf&quot; target=&quot;_blank&quot;&gt;data standards and tools&lt;/a&gt; as well as &lt;a href=&quot;https://www.dfg.de/resource/blob/171632/383249f00d425a643bd8c120404bbff6/standards-sprachkorpora-data.pdf&quot; target=&quot;_blank&quot;&gt;legal aspects&lt;/a&gt; associated with language corpora (German)</help>
+- &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/antragstellung/forschungsdaten/guidelines_biodiversity_research.pdf&quot; target=&quot;_blank&quot;&gt;Guidelines on the Handling of Research Data in Biodiversity Research (German only)&lt;/a&gt;
+- &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/antragstellung/forschungsdaten/richtlinien_forschungsdaten_bildungsforschung.pdf&quot; target=&quot;_blank&quot;&gt;Guidelines for the provision and use of quantitative data in education research (German only)&lt;/a&gt;
+- &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/antragstellung/forschungsdaten/foerderkriterien_editionen_literaturwissenschaft.pdf&quot; target=&quot;_blank&quot;&gt;Elegibility criteria for funding for scholarly editions in the literary studies (German only)&lt;/a&gt;
+- Recommendations on &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/grundlagen_dfg_foerderung/informationen_fachwissenschaften/geisteswissenschaften/standards_sprachkorpora.pdf&quot; target=&quot;_blank&quot;&gt;data standards and tools&lt;/a&gt; as well as &lt;a href=&quot;https://www.dfg.de/resource/blob/171632/383249f00d425a643bd8c120404bbff6/standards-sprachkorpora-data.pdf&quot; target=&quot;_blank&quot;&gt;legal aspects&lt;/a&gt; associated with language corpora (German only)</help>
 		<help lang="de">Beispiele für fachspezifische Empfehlungen und Richtlinien sind: 
 
 - &lt;a href=&quot;http://www.dfg.de/download/pdf/foerderung/antragstellung/forschungsdaten/richtlinien_forschungsdaten_biodiversitaetsforschung.pdf&quot; target=&quot;_blank&quot;&gt;Richtlinien zum Umgang mit Forschungsdaten in der Biodiversitätsforschung&lt;/a&gt;
@@ -1317,7 +1317,7 @@ Der Umgang mit solchen Daten ist gesetzlich geregelt. Mehr Informationen (zwar a
 
 * &lt;a href=&quot;http://www.gesis.org/fileadmin/upload/forschung/publikationen/gesis_reihen/gesis_methodenberichte/2012/TechnicalReport_2012-07.pdf&quot; target=&quot;_blank&quot;&gt;Uwe Jensen (2012): Leitlinien zum Management von Forschungsdaten. Sozialwissenschaftliche Umfragedaten. GESIS Technical Report 2012|07.&lt;/a&gt; (v.a. S. 13ff.)  
 
-* &lt;a href=&quot;https://www.dfg.de/resource/blob/171632/383249f00d425a643bd8c120404bbff6/standards-sprachkorpora-data.pdf&quot; target=&quot;_blank&quot;&gt;Handreichung: Informationen zu rechtlichen Aspekten bei der Handhabung von Sprachkorpora.&lt;/a&gt; (v.a.  Teil 1.1 und Teil 2.2)</help>
+* &lt;a href=&quot;https://www.dfg.de/resource/blob/171632/383249f00d425a643bd8c120404bbff6/standards-sprachkorpora-data.pdf&quot; target=&quot;_blank&quot;&gt;Handreichung: Informationen zu rechtlichen Aspekten bei der Handhabung von Sprachkorpora.&lt;/a&gt; (v.a. Teil 1.1 und Teil 2.2)</help>
 		<text lang="en">Does this dataset contain personal data?</text>
 		<text lang="de">Enthält dieser Datensatz personenbezogene Daten?</text>
 		<verbose_name lang="en"/>