-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix progress for conditional questions in datasets #1107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyPyDavid
force-pushed
the
progress_conditions_datasets
branch
from
August 7, 2024 07:54
a901f7b
to
2ae3fb3
Compare
MyPyDavid
changed the title
Progress conditions datasets
Fix progress for conditional questions in datasets
Aug 7, 2024
MyPyDavid
commented
Aug 7, 2024
) Signed-off-by: David Wallace <[email protected]>
MyPyDavid
force-pushed
the
progress_conditions_datasets
branch
from
August 7, 2024 13:42
962167a
to
4e99174
Compare
MyPyDavid
commented
Aug 7, 2024
Signed-off-by: David Wallace <[email protected]>
Signed-off-by: David Wallace <[email protected]>
We can merge here, right? |
jochenklar
approved these changes
Aug 13, 2024
thanks, yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #1103
Motivation and Context
How has this been tested?
Catalog xml for testing this use-case
Screenshots (if appropriate)
Types of Changes
Checklist