Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addValueSet in project_questions #1108

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Aug 7, 2024

Run refresh check, progress and navigation update, and conditions check when a new value set is added.

This PR adds updateProgress and updateView to service.js. The idea is, that:

  • updateProgress is called on each service.save and service.addValueSet and service.removeValueSet, and
  • updateView on service.save, but only when service.initView is not called. It contains the check if an optionset needs a refresh, the update of the navigation, and the re-evaluation of the conditions (and was named postSave for a few days).

@jochenklar jochenklar requested a review from MyPyDavid August 9, 2024 15:40
@jochenklar jochenklar self-assigned this Aug 9, 2024
@jochenklar
Copy link
Member Author

Bonus track: the last commit allow to use the navigation when a validation error ist triggered.

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes!

@jochenklar jochenklar merged commit 4aa5db6 into dev-2.2.0 Aug 13, 2024
18 checks passed
@jochenklar jochenklar deleted the fix_add_value_set branch August 13, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants