feat(interview): apply to all [2] #1125

jochenklar · 2024-08-16T15:33:17Z

This PR adds the possibility to make projects to all users (#152)

Visible projects can be accessed read only and can be used as template
In a multi site setup, project visibility can be restricted to sites
Project visibility can also be restricted to groups
For now site manager can set the visibility, but this might be changed in the future

To that purpose, it adds a copyValue action to the new interface, which can be used to copy values to different tabs of a page.

It also makes the add value button for questions a bit smaller.

MyPyDavid

this is front-end only, so it does not require any tests 😶‍🌫️

Ive tried out answering some questions and applying the answers to other datasets, it functions intuitively.

One problem I found for the multiple text answer types, where I could not see the button "apply to all" anymore after filling-out and removing again. Are these values not properly compared? And should I also be able to apply-to-all after i just add another entry or not?

Another thing is about the radio buttons, they are floating over, but it's not for this PR I guess, see picture.

rdmo/projects/assets/js/interview/components/main/question/QuestionCopyValue.js

jochenklar · 2024-11-12T13:48:26Z

The radio button problem should be fixed in 24f6831.

jochenklar · 2024-11-12T13:58:46Z

About the apply to all, it works like expected (by me 😄 ). It apears only if the question in at least one of the "sibling" sets has no or only empty values. Maybe we discuss how the feature should work when showing it to more users.

…n questions

jochenklar · 2024-12-12T14:54:37Z

Rebased and good to go!

MyPyDavid · 2024-12-13T12:53:32Z

So, with the behaviour of the checkboxes I can only add selected checkboxes and not remove unselected checkboxes when I apply to all.
Is this the desired behaviour? For consistency I would expect that the whole set of selected und unselected checkboxes will be applied to another dataset. I know that the unselected Values are deleted and just gone right, but would it be possible to implement this via the React state?

jochenklar · 2025-01-06T12:25:50Z

The behavior was a bit odd, because of a bug. The idea was that values are not copied when any value exists "on the receiving side" (which is not what you describe, lets discuss this later in a call or so). initValue did create an empty value for checkboxes as well, thats why the copy arrow apeared (for a first set) just after creating a second set, but not after a reload. I fixed this and then refactored the check in QuestionsCopyValue to check for each "other" set if there are empty values or none at all.

rdmo/projects/assets/js/interview/utils/value.js

MyPyDavid · 2025-01-08T10:24:29Z

rdmo/projects/assets/js/interview/utils/value.js

  sets.filter((set) => set.set_prefix === setPrefix).forEach((set) => {
    element.elements.filter((e) => (e.model === 'questions.question')).forEach((question) => {
+      // check if there is any value for this question and set
      if (isNil(values.find((value) => (
        (value.attribute === question.attribute) &&
        (value.set_prefix == set.set_prefix) &&
        (value.set_index == set.set_index)


do these need to be strict === as well?

in principle == would be ok, I guess but I will change it (JS is weird).

MyPyDavid · 2025-01-08T10:34:06Z

from local testing the interview, now the "Apply this answer to all tabs where this question is empty" behaves accordingly.

As a side note, from a UX, I maybe would expect a button to erase (uncheck) all check-boxes but that's not for this PR.

jochenklar · 2025-01-09T09:36:44Z

I added the erase button to the checkboxes, it was not to complicated. I don't know why I did not add it in the first place.

MyPyDavid · 2025-01-09T12:37:46Z

When reopening the interview in an existing project, at a checkbox question I got the "existing value" conflict validation error.

conflict: [ "An existing value for this attribute/set_prefix/set_index/collection_index was found." ]

but it was only initially, after that I tried to make another Dataset and could check the boxes in there.

PS
For a newly created project, it seems to be fine.

MyPyDavid · 2025-01-09T13:20:13Z

When I apply here to all

Set I
Yes/No

    [http://example.com/terms/questions/catalog/conditions/set/bool](http://localhost:8000/management/questions/101/)
    [http://example.com/terms/domain/conditions/set/bool](http://localhost:8000/management/attributes/114/)

then it also applies to the next question

Set II
Yes/No

    [http://example.com/terms/questions/catalog/conditions/set_set/bool](http://localhost:8000/management/questions/102/)
    [http://example.com/terms/domain/conditions/set/bool](http://localhost:8000/management/attributes/114/)

Is that a bug?

jochenklar · 2025-01-09T16:47:19Z

No, its the same attribute. However, you found a different bug 🐛. The Set II does not work because resolving the condition for the questionset was not triggered. It should be fixed now.

jochenklar · 2025-01-09T16:49:01Z

About the other thing, maybe there was a faulty value in your database from tests before.

MyPyDavid

very nice, thanks!

jochenklar self-assigned this Aug 16, 2024

jochenklar added this to the RDMO 2.3.0 milestone Aug 16, 2024

jochenklar force-pushed the interview-visibility branch from 199863c to be2dea7 Compare August 25, 2024 16:09

jochenklar force-pushed the interview-apply-to-all branch from 5c65410 to 498ae19 Compare August 25, 2024 16:14

MyPyDavid requested changes Nov 7, 2024

View reviewed changes

MyPyDavid reviewed Nov 7, 2024

View reviewed changes

rdmo/projects/assets/js/interview/components/main/question/QuestionCopyValue.js Outdated Show resolved Hide resolved

jochenklar changed the title ~~Interview apply to all~~ feature(interview): apply to all [2] Nov 19, 2024

jochenklar changed the title ~~feature(interview): apply to all [2]~~ feat(interview): apply to all [2] Nov 19, 2024

jochenklar force-pushed the interview-visibility branch from be2dea7 to 493f4b5 Compare December 6, 2024 08:53

Base automatically changed from interview-visibility to 2.3.0 December 12, 2024 14:29

jochenklar added 6 commits December 12, 2024 15:33

Fix set creation

3e7c639

Fix valueIndex computation, again

f0bcc1a

Fix CheckboxInput component

85a7797

Fix interviewReducer

a0875f0

Add copyValue action to interview

bf44cb7

Check siblings for copyValues and use copyValues for all is_collectio…

5ec0b86

…n questions

jochenklar force-pushed the interview-apply-to-all branch from 498ae19 to 5ec0b86 Compare December 12, 2024 14:52

Fix propTypes for QuestionCopyValue

7e74ab9

jochenklar marked this pull request as ready for review December 12, 2024 14:54

jochenklar requested a review from MyPyDavid December 12, 2024 14:54

Fix QuestionCopyValues

c1146d4

MyPyDavid reviewed Jan 8, 2025

View reviewed changes

rdmo/projects/assets/js/interview/utils/value.js Show resolved Hide resolved

MyPyDavid reviewed Jan 8, 2025

View reviewed changes

Use === in initValues

39c32c3

Add QuestionEraseValues component for checkboxes

ccd3cd8

MyPyDavid self-requested a review January 9, 2025 10:13

Fix initQuestionSet

fbe188a

MyPyDavid approved these changes Jan 10, 2025

View reviewed changes

jochenklar merged commit 0ddc19d into 2.3.0 Jan 10, 2025
19 checks passed

jochenklar deleted the interview-apply-to-all branch January 10, 2025 12:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(interview): apply to all [2] #1125

feat(interview): apply to all [2] #1125

jochenklar commented Aug 16, 2024 •

edited

Loading

MyPyDavid left a comment

jochenklar commented Nov 12, 2024

jochenklar commented Nov 12, 2024

jochenklar commented Dec 12, 2024

MyPyDavid commented Dec 13, 2024

jochenklar commented Jan 6, 2025

MyPyDavid Jan 8, 2025

jochenklar Jan 9, 2025

MyPyDavid commented Jan 8, 2025

jochenklar commented Jan 9, 2025

MyPyDavid commented Jan 9, 2025 •

edited

Loading

MyPyDavid commented Jan 9, 2025 •

edited

Loading

jochenklar commented Jan 9, 2025

jochenklar commented Jan 9, 2025

MyPyDavid left a comment

feat(interview): apply to all [2] #1125

feat(interview): apply to all [2] #1125

Conversation

jochenklar commented Aug 16, 2024 • edited Loading

MyPyDavid left a comment

Choose a reason for hiding this comment

jochenklar commented Nov 12, 2024

jochenklar commented Nov 12, 2024

jochenklar commented Dec 12, 2024

MyPyDavid commented Dec 13, 2024

jochenklar commented Jan 6, 2025

MyPyDavid Jan 8, 2025

Choose a reason for hiding this comment

jochenklar Jan 9, 2025

Choose a reason for hiding this comment

MyPyDavid commented Jan 8, 2025

jochenklar commented Jan 9, 2025

MyPyDavid commented Jan 9, 2025 • edited Loading

MyPyDavid commented Jan 9, 2025 • edited Loading

jochenklar commented Jan 9, 2025

jochenklar commented Jan 9, 2025

MyPyDavid left a comment

Choose a reason for hiding this comment

jochenklar commented Aug 16, 2024 •

edited

Loading

MyPyDavid commented Jan 9, 2025 •

edited

Loading

MyPyDavid commented Jan 9, 2025 •

edited

Loading