Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add current site to editors (sites) in create element Factories #824 #827

Merged
merged 1 commit into from
Nov 30, 2023
Merged

feat: add current site to editors (sites) in create element Factories #824 #827

merged 1 commit into from
Nov 30, 2023

Conversation

MyPyDavid
Copy link
Member

@MyPyDavid MyPyDavid commented Nov 16, 2023 •
edited
Loading

Description

Related issue: #824

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MyPyDavid MyPyDavid force-pushed the 824-set-current-site-as-editor-when-creating branch from 9ee9ffe to b28f25b Compare November 16, 2023 10:00
@MyPyDavid MyPyDavid linked an issue Nov 16, 2023 that may be closed by this pull request
The current site should be added to sites and editors when creating a new element #824
Closed
@coveralls
Copy link

coveralls commented Nov 16, 2023 •
edited
Loading

Coverage Status

coverage: 80.917%. remained the same
when pulling 6441d6c on 824-set-current-site-as-editor-when-creating
into a54867e on master.

@MyPyDavid MyPyDavid marked this pull request as ready for review November 16, 2023 12:44
@MyPyDavid MyPyDavid requested a review from jochenklar November 16, 2023 12:45
@MyPyDavid
Copy link
Member Author

Ive just added editors and sites to the create Factories, think its sufficient. Think so too?

@jochenklar
Copy link
Member

How does that behave without MULTISITE = True. I think we should leave the fields open when not using sites. E.g. when extending to multi-site-RDMO elements should initially be visible/editable for/from all sites.

@MyPyDavid MyPyDavid added the javascript Pull requests that update Javascript code label Nov 21, 2023
@MyPyDavid MyPyDavid force-pushed the 824-set-current-site-as-editor-when-creating branch from b28f25b to 6441d6c Compare November 21, 2023 09:43
@MyPyDavid
Copy link
Member Author

ok, I've added now as the default value

editors: config.settings.multisite ? [config.currentSite.id] : [],

@MyPyDavid MyPyDavid changed the base branch from master to dev-2.1.0 November 21, 2023 16:05
@MyPyDavid MyPyDavid added this to the 2.1.0 milestone Nov 21, 2023
@jochenklar jochenklar merged commit 6c4bcd2 into dev-2.1.0 Nov 30, 2023
12 checks passed
@jochenklar jochenklar deleted the 824-set-current-site-as-editor-when-creating branch December 12, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochenklar jochenklar jochenklar approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code status:done type:feature-request
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

The current site should be added to sites and editors when creating a new element
3 participants
@MyPyDavid @coveralls @jochenklar