Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: batch update javascript dependencies #837

Closed
wants to merge 14 commits into from
Closed

build: batch update javascript dependencies #837

wants to merge 14 commits into from

Conversation

afuetterer
Copy link
Member

Description

This PR proposes the following changes:

  • update the Javascript dependencies in multiple grouped commits
  • alter the dependabot config slightly (move copy-webpack-plugin to the more fitting webpack update group
  • update the used versions of eslint and react plugin in pre-commit config

Types of Changes

  • Build related changes

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • All new and existing tests passed.

afuetterer and others added 14 commits November 19, 2023 17:29
@afuetterer
ci: add dependency groups to dependabot config
003f8ad
@afuetterer
chore: update ruff repo name in pre-commit config
749b764
@github-actions @afuetterer
build: update pre-commit hooks
25276fa
@afuetterer
chore: fix ruff errors (PGH002, UP032)
9b73bcb
@afuetterer
Merge pull request rdmorganiser#834 from afuetterer/811-dependabot-gr…
69aaae6 
…oups

ci: add dependency groups to dependabot config
@afuetterer
ci: update dependabot js groups
85dde15
@dependabot @afuetterer
build(deps-dev): bump the babel group with 5 updates
8dde1a4 
Bumps the babel group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) | `7.17.10` | `7.23.4` |
| [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.17.10` | `7.23.3` |
| [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) | `7.17.10` | `7.23.3` |
| [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) | `7.16.7` | `7.23.3` |
| [babel-loader](https://github.com/babel/babel-loader) | `8.2.5` | `9.1.3` |

Updates `@babel/cli` from 7.17.10 to 7.23.4
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.4/packages/babel-cli)

Updates `@babel/core` from 7.17.10 to 7.23.3
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-core)

Updates `@babel/preset-env` from 7.17.10 to 7.23.3
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-preset-env)

Updates `@babel/preset-react` from 7.16.7 to 7.23.3
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-preset-react)

Updates `babel-loader` from 8.2.5 to 9.1.3
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.2.5...v9.1.3)

---
updated-dependencies:
- dependency-name: "@babel/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: "@babel/preset-react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: babel
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @afuetterer
build(deps): bump the react group with 3 updates
f0d0edb 
Bumps the react group with 3 updates: [react-bootstrap](https://github.com/react-bootstrap/react-bootstrap), [react-redux](https://github.com/reduxjs/react-redux) and [react-select](https://github.com/JedWatson/react-select).

Updates `react-bootstrap` from 0.33.1 to 2.9.1
- [Release notes](https://github.com/react-bootstrap/react-bootstrap/releases)
- [Changelog](https://github.com/react-bootstrap/react-bootstrap/blob/master/CHANGELOG.md)
- [Commits](react-bootstrap/react-bootstrap@v0.33.1...v2.9.1)

Updates `react-redux` from 7.2.8 to 8.1.3
- [Release notes](https://github.com/reduxjs/react-redux/releases)
- [Changelog](https://github.com/reduxjs/react-redux/blob/master/CHANGELOG.md)
- [Commits](reduxjs/react-redux@v7.2.8...v8.1.3)

Updates `react-select` from 5.7.0 to 5.8.0
- [Release notes](https://github.com/JedWatson/react-select/releases)
- [Changelog](https://github.com/JedWatson/react-select/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/JedWatson/react-select/compare/[email protected]@5.8.0)

---
updated-dependencies:
- dependency-name: react-bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: react
- dependency-name: react-redux
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: react
- dependency-name: react-select
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: react
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @afuetterer
build(deps): bump the redux group with 1 update
a5a4e32 
Bumps the redux group with 1 update: [redux](https://github.com/reduxjs/redux).

- [Release notes](https://github.com/reduxjs/redux/releases)
- [Changelog](https://github.com/reduxjs/redux/blob/master/CHANGELOG.md)
- [Commits](reduxjs/redux@v4.2.0...v4.2.1)

---
updated-dependencies:
- dependency-name: redux
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: redux
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @afuetterer
build(deps-dev): bump the webpack group with 4 updates
a59b370 
Bumps the webpack group with 4 updates: [copy-webpack-plugin](https://github.com/webpack-contrib/copy-webpack-plugin), [webpack](https://github.com/webpack/webpack), [webpack-cli](https://github.com/webpack/webpack-cli) and [webpack-merge](https://github.com/survivejs/webpack-merge).

Updates `copy-webpack-plugin` from 8.1.1 to 11.0.0
- [Release notes](https://github.com/webpack-contrib/copy-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/copy-webpack-plugin@v8.1.1...v11.0.0)

Updates `webpack` from 5.72.0 to 5.89.0
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.72.0...v5.89.0)

Updates `webpack-cli` from 4.9.2 to 5.1.4
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/[email protected]@5.1.4)

Updates `webpack-merge` from 5.7.3 to 5.10.0
- [Changelog](https://github.com/survivejs/webpack-merge/blob/develop/CHANGELOG.md)
- [Commits](survivejs/webpack-merge@v5.7.3...v5.10.0)

---
updated-dependencies:
- dependency-name: copy-webpack-plugin
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: webpack
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: webpack
- dependency-name: webpack-cli
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: webpack
- dependency-name: webpack-merge
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: webpack
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @afuetterer
build(deps-dev): bump the eslint group with 2 updates
23f779a 
Bumps the eslint group with 2 updates: [eslint](https://github.com/eslint/eslint) and [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react).

Updates `eslint` from 8.41.0 to 8.54.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.41.0...v8.54.0)

Updates `eslint-plugin-react` from 7.32.2 to 7.33.2
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.32.2...v7.33.2)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint-plugin-react
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@afuetterer
chore: bump eslint versions in pre-commit config
6275599
@dependabot @afuetterer
build(deps-dev): bump the dev-dependencies group with 4 updates
6a89227 
Bumps the dev-dependencies group with 4 updates: [css-loader](https://github.com/webpack-contrib/css-loader), [mini-css-extract-plugin](https://github.com/webpack-contrib/mini-css-extract-plugin), [sass](https://github.com/sass/dart-sass) and [sass-loader](https://github.com/webpack-contrib/sass-loader).

Updates `css-loader` from 5.2.7 to 6.8.1
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/css-loader@v5.2.7...v6.8.1)

Updates `mini-css-extract-plugin` from 1.6.2 to 2.7.6
- [Release notes](https://github.com/webpack-contrib/mini-css-extract-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/mini-css-extract-plugin@v1.6.2...v2.7.6)

Updates `sass` from 1.55.0 to 1.69.5
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.55.0...1.69.5)

Updates `sass-loader` from 11.1.1 to 13.3.2
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases)
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/sass-loader@v11.1.1...v13.3.2)

---
updated-dependencies:
- dependency-name: css-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: dev-dependencies
- dependency-name: mini-css-extract-plugin
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: dev-dependencies
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: sass-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @afuetterer
build(deps): bump the prod-dependencies group with 5 updates
0c90c80 
Bumps the prod-dependencies group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [@codemirror/lang-html](https://github.com/codemirror/lang-html) | `6.4.2` | `6.4.6` |
| [@codemirror/lang-javascript](https://github.com/codemirror/lang-javascript) | `6.1.4` | `6.2.1` |
| [@uiw/react-codemirror](https://github.com/uiwjs/react-codemirror) | `4.19.9` | `4.21.20` |
| [jquery](https://github.com/jquery/jquery) | `3.6.0` | `3.7.1` |
| [js-cookie](https://github.com/js-cookie/js-cookie) | `2.2.1` | `3.0.5` |

Updates `@codemirror/lang-html` from 6.4.2 to 6.4.6
- [Changelog](https://github.com/codemirror/lang-html/blob/main/CHANGELOG.md)
- [Commits](codemirror/lang-html@6.4.2...6.4.6)

Updates `@codemirror/lang-javascript` from 6.1.4 to 6.2.1
- [Changelog](https://github.com/codemirror/lang-javascript/blob/main/CHANGELOG.md)
- [Commits](codemirror/lang-javascript@6.1.4...6.2.1)

Updates `@uiw/react-codemirror` from 4.19.9 to 4.21.20
- [Release notes](https://github.com/uiwjs/react-codemirror/releases)
- [Commits](uiwjs/react-codemirror@v4.19.9...v4.21.20)

Updates `jquery` from 3.6.0 to 3.7.1
- [Release notes](https://github.com/jquery/jquery/releases)
- [Commits](jquery/jquery@3.6.0...3.7.1)

Updates `js-cookie` from 2.2.1 to 3.0.5
- [Release notes](https://github.com/js-cookie/js-cookie/releases)
- [Changelog](https://github.com/js-cookie/js-cookie/blob/main/.release-it.json)
- [Commits](js-cookie/js-cookie@v2.2.1...v3.0.5)

---
updated-dependencies:
- dependency-name: "@codemirror/lang-html"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: prod-dependencies
- dependency-name: "@codemirror/lang-javascript"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-dependencies
- dependency-name: "@uiw/react-codemirror"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-dependencies
- dependency-name: jquery
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prod-dependencies
- dependency-name: js-cookie
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: prod-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@afuetterer afuetterer requested a review from MyPyDavid November 23, 2023 08:36
@afuetterer
Copy link
Member Author

These are all the updates the Dependabot made to my fork today, so JS dependencies should be up to date. The grouping works fine. We can always reduce the number of the groups later. But this a step forward from having dozens of PRs dangling around.

The frontend tests passed in my fork. Maybe you could look at the management frontend manually with the wheel from this PR @MyPyDavid?

@MyPyDavid
Copy link
Member

MyPyDavid commented Nov 23, 2023 •
edited
Loading

yes, good idea but now there is no artifact in the PR.

Artifacts
–

Maybe the rdmorganiser:dependency-updates still needs be updated with a rebase or?
PR: #838

@afuetterer
Copy link
Member Author

You are right, the build-wheel is not available in dependency-updates.

@MyPyDavid
Copy link
Member

alright, branch is updated and it's running again, i'll check afterwards for the artifact

@afuetterer
Copy link
Member Author

Now I need to rebase my branch as well. There are some commits in this PR, that are already on the dependency-updates branch. I will fix this later.

@afuetterer afuetterer closed this Nov 23, 2023
@afuetterer afuetterer deleted the dependency-updates branch November 23, 2023 18:15
@afuetterer
Copy link
Member Author

See #839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid Awaiting requested review from MyPyDavid

Assignees
No one assigned
Labels
type:maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afuetterer @MyPyDavid