Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add the django-shibboleth-remoteuser fork #828 #840

Conversation

MyPyDavid
Copy link
Member

@MyPyDavid MyPyDavid commented Nov 24, 2023

Description

Related issue: #828

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MyPyDavid MyPyDavid added type:maintenance dependencies Pull requests that update a dependency file labels Nov 24, 2023
@MyPyDavid MyPyDavid self-assigned this Nov 24, 2023
@MyPyDavid MyPyDavid requested a review from afuetterer November 24, 2023 09:04
Copy link
Member

@afuetterer afuetterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the optional dependency group shibboleth to the optional-dependencies job in CI.

Then the dependency would be installed in CI and we'll see, if
a) the dependency is "installable"
b) if there are conflicts with other optional dependencies

- run: python -m pip install .[allauth,ci,dev,gunicorn,ldap,mysql,postgres,pytest]

@MyPyDavid MyPyDavid force-pushed the 828-add-the-django-shibboleth-remoteuser-fork-to-pyprojecttoml branch from fec23ca to fc9d2ea Compare November 24, 2023 10:29
@MyPyDavid MyPyDavid requested a review from afuetterer November 24, 2023 10:29
@afuetterer
Copy link
Member

Looks good to me.

Forked django-shibboleth-remoteuser is installed alright.
https://github.com/rdmorganiser/rdmo/actions/runs/6979630741/job/18993276758#step:7:42

@afuetterer
Copy link
Member

We talked about this dependency last time, right?

The original repo now has a version 0.12 avaible.
https://github.com/Brown-University-Library/django-shibboleth-remoteuser/tags

But this is another issue.

@jochenklar
Copy link
Member

I already rebased our fork to the current upstream master.

@MyPyDavid MyPyDavid merged commit b1f36d1 into dev-2.1.0 Nov 24, 2023
12 checks passed
@MyPyDavid MyPyDavid linked an issue Dec 5, 2023 that may be closed by this pull request
@jochenklar jochenklar deleted the 828-add-the-django-shibboleth-remoteuser-fork-to-pyprojecttoml branch December 12, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type:maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add the django-shibboleth-remoteuser fork to pyproject.toml
3 participants