fix: add required dependency packaging #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The packaging library is used in rdmo/core/xml.py.
|
The import of packaging was introduced last week via d511cb8. It was not a production requirement before. |
|
Ah sorry, my bad. Thanks for the PR. |
jochenklar
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
packaginglibrary is used inrdmo/core/xml.py, but it was not listed in the requirements. If users install rdmo without rdmo[dev], they do not install pytest. Pytest installs packaging in CI, so the error never showed in CI.Motivation and Context
@jochenklar mentioned this in the slack channel. I can confirm, that simply installing rdmo, does not install packaging.
Types of Changes
Checklist