Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

858 filter in managment should be case insensitive #859

Merged
merged 1 commit into from
Dec 5, 2023
Merged

858 filter in managment should be case insensitive #859

merged 1 commit into from
Dec 5, 2023

Conversation

MyPyDavid
Copy link
Member

@MyPyDavid MyPyDavid commented Dec 4, 2023 •
edited
Loading

Description

Related issue: #858

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MyPyDavid MyPyDavid added this to the 2.1.0 milestone Dec 4, 2023
@MyPyDavid MyPyDavid self-assigned this Dec 4, 2023
@MyPyDavid MyPyDavid linked an issue Dec 4, 2023 that may be closed by this pull request
filter in managment should be case insensitive #858
Closed
@MyPyDavid MyPyDavid added the javascript Pull requests that update Javascript code label Dec 4, 2023
@MyPyDavid MyPyDavid changed the base branch from master to dev-2.1.0 December 4, 2023 10:42
@MyPyDavid MyPyDavid requested a review from jochenklar December 4, 2023 10:43
@MyPyDavid
Copy link
Member Author

Would this be ok for 2.1.0 @jochenklar?
Makes both element.title (and text) and search to lower case.

@jochenklar
Copy link
Member

I guess. Does it work?

@MyPyDavid
Copy link
Member Author

yes, I've tested it locally in runserver

@MyPyDavid MyPyDavid merged commit f118f9b into dev-2.1.0 Dec 5, 2023
13 checks passed
@jochenklar jochenklar deleted the 858-filter-in-managment-should-be-case-insensitive branch December 12, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochenklar jochenklar jochenklar approved these changes

Assignees

@MyPyDavid MyPyDavid

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

filter in managment should be case insensitive
2 participants
@MyPyDavid @jochenklar