Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use react-native-safe-area-context #78

Closed
wants to merge 2 commits into from

Conversation

blakef
Copy link
Collaborator

@blakef blakef commented Nov 5, 2024

We're recommending using react-native-safe-area-context instead of SafeAreaView for Android 15 targetSDK = 35.

With StatusBar Without StatusBar
e2e e2e-hidden-status-bar

@blakef blakef requested a review from cortinico November 5, 2024 13:03
@blakef
Copy link
Collaborator Author

blakef commented Nov 5, 2024

CC @alanleedev

@blakef
Copy link
Collaborator Author

blakef commented Nov 13, 2024

We can't land this change until we figure out a couple of things. At the moment when I use the react-native-safe-area-context library, this doesn't work edge-to-edge:

Baseline

CleanShot 2024-11-13 at 10 31 00@2x

Using react-native-safe-area-context:

CleanShot 2024-11-12 at 21 13 15@2x

@blakef
Copy link
Collaborator Author

blakef commented Nov 13, 2024

@alanleedev
Copy link
Collaborator

Closing in favor of new approach: #85

@alanleedev alanleedev closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants