added accessibility id as a locator #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naturalclar
requested changes
Oct 31, 2024
There was a problem hiding this comment.
@rvenky125 thanks for the changes! could you address the lint error?
|
Yes, will update the pr asap |
rvenky125
force-pushed
the
feat/testIDS_for_segments
branch
from
da3d4be to
ee9f928
Compare
|
Hey @Naturalclar, I addressed those checks, Thank you. |
Naturalclar
merged commit 5f72e50
into
react-native-segmented-control:master
2 of 5 checks passed
|
Hey @Naturalclar, thanks for merging; I'm eagerly waiting for a new release |
|
@rvenky125 thanks for the ping! released v2.5.6 with changes included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Thank you very much for merging the previous PR, and I would kindly request that you please merge this one as we need the accessibility locator also, and it's useful for many of the users.
Test Plan
You can just check if the locator is reflecting as accessibility-id in Appium Inspector.