Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-started.md | Removes deprecation warning for webpackconfig in favor of generateWebpackConfig #1337

Merged
merged 1 commit into from
May 10, 2024

Conversation

chmod600
Copy link
Contributor

@chmod600 chmod600 commented Apr 27, 2024

Summary

Using webpackconfig throws a deprecation warning and encourages user to use generateWebpackConfig() instead. Updates docs to avoid this deprecation warning.

Other Information

Output: 

 $ ./bin/shakapacker-dev-server
⚠️
DEPRECATION NOTICE:
The 'webpackConfig' is deprecated and will be removed in a future version.
Please use 'globalMutableWebpackConfig' instead, or use
'generateWebpackConfig()' to avoid unwanted config mutation across the app.

For more information, see version 7 upgrade documentation at:
https://github.com/shakacode/shakapacker/blob/master/docs/v7_upgrade.md

Pull Request checklist

  • [x ] Add/update test to cover these changes
  • [ x] Update documentation
  • [ x] Update CHANGELOG file

Using webpackconfig throws a deprecation warning and encourages user to use generateWebpackConfig() instead.
Copy link
Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

});
const webpackConfig = generateWebpackConfig()

module.exports = merge(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking, but fwiw this can be simplified further as generateWebpackConfig now takes a config to be merged in:

module.exports = generateWebpackConfig({
    plugins: [new ForkTsCheckerWebpackPlugin()]
});

@justin808 justin808 merged commit 151d333 into reactjs:master May 10, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants