Fix crash when disable command is preceded by unicode character #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
SimplyDanny
force-pushed
the
unicode-before-command
branch
from
5905446 to
db786b3
Compare
| @@ -60,35 +62,54 @@ struct InvalidSwiftLintCommandRule: Rule, SourceKitFreeRule { | |||
|
|
|||
| private func styleViolation(for command: Command, in file: SwiftLintFile, reason: String) -> StyleViolation { | |||
| let character = command.startingCharacterPosition(in: file) | |||
| let characterOffset = character.flatMap { | |||
There was a problem hiding this comment.
So I think we could make the characterOffset retrieval a function on the Command extension, so this reads more nicely here, but having to do all of these line calculations feels a bit off in general.
The reason we have to do this calculations is because Command's character property records the character beyond the end of the command. If that instead recorded the start of the command, which is where this rule places the violation, then we could ditch all of this code.
I think that might be possible, but something we could look at separately.
| @@ -18,6 +18,9 @@ | |||
|
|
|||
| * Fix issue referencing the Tests package from another Bazel workspace. | |||
| [jszumski](https://github.com/jszumski) | |||
| * Fix crash when a disable command is preceded by a unicode character. | |||
There was a problem hiding this comment.
Maybe a blank line here?
mildm8nnered
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5945.