(RHEL-26133) efi: force .sbat and .sdmagic sections to be 512 bytes #247
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tracker/missing
Commit validationTracker - RHEL-26133 The following commits need an inspection
Tracker validationFailed🔴 Tracker RHEL-26133 is missing severity Success🟢 Tracker RHEL-26133 has set desired product: Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
In https://issues.redhat.com/browse/RHEL-26133 we're having issues with section alignment when objcopy from older bintils is used. IIUC, the short sections are causing the following section to be not aligned. To sidestep the problem, let's make the sections 512 bytes. $ diff -u <(objdump -h build/src/boot/efi/linuxx64.efi.stub.0) <(objdump -h build/src/boot/efi/linuxx64.efi.stub)|cat --- /proc/self/fd/11 2024-03-22 11:58:47.427094850 +0100 +++ /proc/self/fd/13 2024-03-22 11:58:47.422094852 +0100 @@ -1,5 +1,5 @@ -build/src/boot/efi/linuxx64.efi.stub.0: file format pei-x86-64 +build/src/boot/efi/linuxx64.efi.stub: file format pei-x86-64 Sections: Idx Name Size VMA LMA File off Algn @@ -15,7 +15,7 @@ CONTENTS, ALLOC, LOAD, READONLY, DATA 5 .dynsym 00000018 0000000000026000 0000000000026000 0001d000 2**2 CONTENTS, ALLOC, LOAD, READONLY, DATA - 6 .sbat 000000e6 00000000000289e0 00000000000289e0 0001d200 2**2 + 6 .sbat 00000200 00000000000289e0 00000000000289e0 0001d200 2**2 CONTENTS, ALLOC, LOAD, READONLY, DATA - 7 .sdmagic 00000038 0000000000028ae0 0000000000028ae0 0001d400 2**2 + 7 .sdmagic 00000200 0000000000028be0 0000000000028be0 0001d400 2**2 CONTENTS, ALLOC, LOAD, READONLY, DATA Related: RHEL-26133
keszybz
force-pushed
the
rhel-9.4.0-make-sections-bigger
branch
from
2c869c1 to
3d0ba23
Compare
github-actions
bot
changed the title
github-actions
bot
added
pr/needs-ci
|
In #248 I backported the recently introduced upstream test that can be used for testing this. |
github-actions
bot
added
tracker/missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://issues.redhat.com/browse/RHEL-26133 we're having issues with section alignment when objcopy from older bintils is used. IIUC, the short sections are causing the following section to be not aligned. To sidestep the problem, let's make the sections 512 bytes.