Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where the cursor tag is not used for an empty string in displayLineWithAlignment #78

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

minimapletinytools
Copy link
Member

No description provided.

-- manually handle empty case because mapaccumlfn doesn't handle it
then ((0, Right (0, alignmentOffset alignment width "")), [[Span tag ""]])
then ((0, Right (0, alignmentOffset alignment width "")), [[Span cursorTag ""]])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only real change in this PR

apologies for the other minor formatting changes.
I'm maintaining a separate version of this file and I use a different linter or something like that.

@minimapletinytools
Copy link
Member Author

BTW I'm getting ready to release tinytools before EoY
There might be a few more bug fixes I attempt to merge into here before then. I can also release without this fix so no rush to release on hackage.

@ali-abrar ali-abrar merged commit a55b4c2 into reflex-frp:develop Jan 25, 2024
13 checks passed
@ali-abrar ali-abrar mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants