-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Manifest V3 on Chrome #166
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks for upgrading it. The changes are so clean.
@tyao1 seems like the pipeline is broken (related to a bad node version), have we encountered this before or is this new? |
@tyao1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NVM my bad, I didnt see that you've already updated the node version :D |
@Asymons has updated the pull request. You must reimport the pull request before landing. |
@tyao1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Asymons I tried it locally and built the unpacked version with Did you get the same error? |
Description
Support for Manifest V2 is coming close to an end (seems to be June 2025) so in order to maintain this project, we need to upgrade to Manifest V3.
This also removes the warning from the Chrome Extensions Web Store.
The changes are quite simple and deviate slightly from the implementation in react-devtools. I originally thought to follow what was done there but quickly came to understand I was introducing a bunch of unnecessary code and abstraction that may not be needed for this project.
The upgrade to Manifest V3 from V2 requires a few changes, primarily related to security, so here's what we did:
Tests
I basically ran everything on Chrome as it seems Firefox isn't supported (had some trouble getting it running personally). I ran our light unit tests
yarn test
and the video below demonstrates me poking around a website that supports Relay.Screen.Recording.2025-01-03.at.9.35.42.PM.mov