Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-router): add LayoutComponentProps type #12543

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat(react-router): add LayoutComponentProps type #12543

wants to merge 3 commits into from

Conversation

AlemTuzlak
Copy link
Contributor

Add the LayoutComponentProps utility type instead of us having to manually define it in our projects

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d1476a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title feat: Add LayoutComponentProps utility type feat(react-router): add LayoutComponentProps type Dec 13, 2024
MichaelDeBoey
MichaelDeBoey requested changes Dec 13, 2024
View reviewed changes
packages/react-router/lib/router/utils.ts Outdated Show resolved Hide resolved
packages/react-router/lib/router/utils.ts Outdated Show resolved Hide resolved
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 17, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@AlemTuzlak AlemTuzlak mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey requested changes

@timdorr timdorr timdorr left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed react-router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlemTuzlak @timdorr @MichaelDeBoey