Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local file:// support to elfeed-org #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ma11ock
Copy link

@Ma11ock Ma11ock commented Oct 7, 2021

elfeed began supporting local files for RSS feeds last year but elfeed-org will simply ignore entries that begin with file://. (you ought to look over the patch, it is tested but I'm not great with regex's!)

@Ma11ock
Copy link
Author

Ma11ock commented Oct 23, 2021

@remyhonig Could you look over this pr?

@readmemyrights
Copy link
Contributor

In the same update elfeed added support for gopher, I've added support for both
file:// and gopher:// in my pr #75.

@remyhonig
Copy link
Owner

Sorry for the delay guys. @readmemyrights added support for the file:// notation as well. I just merged it.

@remyhonig
Copy link
Owner

I see more changes than in the PR I mentioned above now looking at it. If the changes in this PR are still needed than please solve conflicts and I'll merge it if it doesn't break the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants