Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken connection handling #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Broken connection handling #5

wants to merge 5 commits into from

Conversation

deavmi
Copy link
Contributor

@deavmi deavmi commented Nov 26, 2023 •
edited
Loading

Purpose ✍️

We want to handle any errors that may occur with Tristanable when we are busy doing a dequeue().

Todo ✅

  • Complete tristanable
  • Shutdown tristanable when we exit the loop
  • Shutdown the river stream
  • Notify server

@deavmi
Connection
44c130c 
- Added some initial error handling to the loop in `worker()`
- If we get a `TristanableException` whilst we are `dequeue()`'ing then we exit the loop
@deavmi deavmi added bug Something isn't working enhancement New feature or request labels Nov 26, 2023
@deavmi deavmi self-assigned this Nov 26, 2023
@deavmi
Connection
7df8054 
- Removed unecessary condition variable
@deavmi
Connection
1567e06 
- Shutdown the tristanable manager on exit of loop
@deavmi
Connection
ecb2267 
- Shutdown the river stream as well
@deavmi
Connection
d281375 
- Added some debugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deavmi deavmi

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deavmi