Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all legacy Chunk iteration APIs #8556

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Remove all legacy Chunk iteration APIs #8556

merged 4 commits into from
Jan 6, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Dec 20, 2024

@teh-cmc teh-cmc added 🏹 arrow concerning arrow 📺 re_viewer affects re_viewer itself 🔍 re_query affects re_query itself do-not-merge Do not merge this PR 🚜 refactor Change the code, not the functionality include in changelog labels Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
d0b7d38 https://rerun.io/viewer/pr/8556 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc marked this pull request as ready for review December 20, 2024 11:07
@teh-cmc teh-cmc force-pushed the cmc/graphedge_struct_slice branch from a757399 to edfc60d Compare December 20, 2024 13:22
@teh-cmc teh-cmc force-pushed the cmc/cleanup_old_iter branch from eab6aa2 to 8af2858 Compare December 20, 2024 13:22
@Wumpf Wumpf self-requested a review January 3, 2025 16:44
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@teh-cmc teh-cmc force-pushed the cmc/graphedge_struct_slice branch from edfc60d to 1293da6 Compare January 6, 2025 08:44
Base automatically changed from cmc/graphedge_struct_slice to main January 6, 2025 08:44
@teh-cmc teh-cmc force-pushed the cmc/cleanup_old_iter branch from 8af2858 to a7a8deb Compare January 6, 2025 08:46
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jan 6, 2025
@teh-cmc teh-cmc merged commit 87902e6 into main Jan 6, 2025
34 checks passed
@teh-cmc teh-cmc deleted the cmc/cleanup_old_iter branch January 6, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow include in changelog 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants