Persist servers and allow adding/removing them from the UI #9086
+596
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
ui
# Conflicts: # crates/viewer/re_redap_browser/src/servers.rs
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
# Conflicts: # Cargo.lock # crates/top/rerun/src/commands/entrypoint.rs # crates/utils/re_uri/src/lib.rs # crates/viewer/re_redap_browser/src/collection_ui.rs # crates/viewer/re_redap_browser/src/servers.rs # crates/viewer/re_viewer/src/app.rs
abey79
commented
Feb 20, 2025
abey79
commented
Feb 20, 2025
| @@ -183,6 +183,7 @@ const_format = "0.2" | |||
| convert_case = "0.6" | |||
| criterion = "0.5" | |||
| crossbeam = "0.8" | |||
| crossbeam-channel = "0.5" | |||
There was a problem hiding this comment.
was already in the dependency tree
Wumpf
approved these changes
Feb 20, 2025
| use re_viewer_context::{AsyncRuntimeHandle, WasmNotSend}; | ||
|
|
||
| /// A handle to an object that is requested asynchronously. | ||
| pub enum RequestedObject<T: Send + 'static> { |
There was a problem hiding this comment.
this turned out really nice and short :)
| pub fn ui(&self, ctx: &ViewerContext<'_>, ui: &mut egui::Ui) { | ||
| //TODO(ab): we should display something even if no catalog is currently selected. | ||
| fn add_server_modal_ui(&mut self, ui: &egui::Ui) { | ||
| //TODO(ab): borrow checker doesn't let me use `with_ctx()` here, I should find a better way |
There was a problem hiding this comment.
ah that pattern is tricky, don't know either. Oooooonnneeee day the Polonius borrow checker will solve this, any decade now
There was a problem hiding this comment.
in fairness, pulling that off would be pretty great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With this PR, the servers are now persisted across viewer relaunch in the Redap browser, and the can be added and removed from the UI. The handling of the collection query management has been improved, so was its UI.
Note: this makes a pre-existing
crossbeam-channeldependency explicit.Add/remove buttons:
Add server modal: